? Success
Duplicate of # 6080

User tests: Successful: Unsuccessful:

avatar clinchergt
clinchergt
28 Apr 2015

Not sure why they were strings before. They're assumed to be booleans later on when they're used in JS at this line: https://github.com/joomla/joomla-cms/blob/staging/media/system/js/tabs.js#L45

Reason for not removing the true and false values since they're redundant: joomla/coding-standards#88

Steps to reproduce

  1. Create tabs using something like this echo JHtml::_('tabs.start', 'signInPane', array('startOffset' => 2, 'useCookie' => false)); and anything else that's necessary to create the rest of the tabs pane.
  2. Visit the tabs on the frontend.

Expected result

Have the 3rd tab (because of zero indexing) be open. And upon selecting another tab and refreshing, have the 3rd tab still open, and not the last active tab.

avatar clinchergt clinchergt - open - 28 Apr 2015
avatar clinchergt
clinchergt - comment - 28 Apr 2015

This was giving me a headache, and apparently I'm not the first one:
http://joomla.stackexchange.com/questions/5675/how-do-i-set-options-for-jhtmltabs-with-bootstrap

avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Category Libraries
avatar zero-24 zero-24 - change - 29 Apr 2015
Status New Pending
avatar zero-24 zero-24 - change - 29 Apr 2015
Easy No Yes
avatar wilsonge wilsonge - change - 29 Apr 2015
Milestone Added:
avatar gunjanpatel
gunjanpatel - comment - 6 May 2015

This fix is already sent and tested successfully one time #6080 need one more test there. :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6861.

avatar gunjanpatel gunjanpatel - change - 6 May 2015
Rel_Number 0 6080
Relation Type Duplicate of
avatar roland-d
roland-d - comment - 6 May 2015

@clinchergt Thank you for your contribution. I am closing this PR in favor of #6080 as this already has a test.

avatar roland-d roland-d - change - 6 May 2015
Milestone Removed:
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-05-06 05:16:56
Closed_By roland-d
avatar roland-d roland-d - close - 6 May 2015

Add a Comment

Login with GitHub to post a comment