? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
28 Apr 2015

There are a few checks in the code that check the database name property to determine if mysql is the first 5 characters. These checks exclude supporting the PDO MySQL driver since its internal name is pdomysql. This PR changes the checks to determine if mysql is contained in the name or not.

avatar mbabker mbabker - open - 28 Apr 2015
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 29 Apr 2015
Category Libraries
avatar zero-24 zero-24 - change - 29 Apr 2015
Status New Pending
avatar roland-d
roland-d - comment - 5 May 2015

@mbabker If we only named them mysqlpdo ;)

@test success: I have tested this by enabling Debug System in the global configuration. After that load a page and verified that the code is triggered and working as before.

avatar roland-d roland-d - test_item - 5 May 2015 - Tested successfully
avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

Tested by selecting Database Type as a MySQL (PDO) and after placing patch pages looks normal.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6860.

avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

Tested by selecting Database Type as a MySQL (PDO) and after placing patch pages looks normal.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6860.

avatar gunjanpatel
gunjanpatel - comment - 9 May 2015

Note: Sorry for so many comments. Don't know how it is got added, I simply click on Post Comment button only one time. It got chunk and I refresh the page and found this many comments.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6860.

avatar zero-24 zero-24 - alter_testresult - 9 May 2015 - gunjanpatel: Tested successfully
avatar zero-24 zero-24 - change - 9 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 9 May 2015

Thanks for testing. RTC'ing now :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6860.

avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 10 May 2015
avatar wilsonge wilsonge - change - 10 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-10 00:22:25
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 May 2015
avatar wilsonge wilsonge - reference | c8b6bf3 - 10 May 15
avatar wilsonge wilsonge - merge - 10 May 2015
avatar wilsonge wilsonge - close - 10 May 2015
avatar wilsonge
wilsonge - comment - 10 May 2015

Merged - thanks!

avatar wilsonge wilsonge - change - 10 May 2015
Milestone Added:
avatar wilsonge wilsonge - change - 10 May 2015
Milestone Added:
avatar wilsonge wilsonge - change - 10 May 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment