Close / Reopen for TravisCI

That could be nice, easiest to read on deepth menu, and what about adding language if multilangue enabled ?

@Devportobello
Do you mean when a menu has submenu items tagged to different languages in multilang?

@infograf768
Yes, like :

• mainmenu - en-GB

  • home - en-GB
  • Who are we - en-GB

• mainmenu - fr-FR

  • Accueil - fr-FR
  • Qui sommes-nous - fr-FR

That one is not necessary imho as the language is not important in that case.
What "could" be necessary is rather (not tested with this patch):

Mainmenu-ALL
Level 1 => fr-FR item
Level 1 => en-GB item
Level 2 => en-GB item
Level 3 => fr-FR item
etc.

How would it behave if we load that menu in a fr-FR page or in a en-GB page is the matter.

Just noticed what i said is when menu and submenu items tagged to same language... my bad ;)

This patch does not alter the behavior. It just adds visual indicators.

@nueckman i have just tested this but the indicators are only add for the first menu. The others are still without -

see:

Well, that's odd. I will take a look at this.

@nueckman
My bad, you right so my idea need to be in another PR.

@zero-24
Just test and dont got your result

Thanks for checking @Devportobello You are correct it was my issue. I have not in mind that the frontendviews menu don't have any kind levels.

I have just retestet and it works now. Sorry @nueckman for the false alarm

RTC as we have two successful tests

Merged into 3.5-dev branch - thanks!

Well, can't blame myself enough for the typo (wrong parameter).

But i'm not so sure about the second thing (level <= 0). root is the only item which can be level 0, but as you never navigate to root (it's just the root for nested set reasons), i don't know why root should be displayed in the first place.

if "menu_type" params setup => Menuitem field
Then used for querying => Menus helper
lead to add root item

Thanks @Devportobello. What i actually meant was "is it really necessary to show the root?"

ye right question, i dont know why this is needed too.

Do you want to create a PR for the other issue (wrong parameter)? In the meanwhile i will dig through the code.

Still no clue. But we could ask @eddieajau about his commit several years ago ;) (70accbd)

There seems to be no reason why getMenuLinks does select the root.

@zero-24 not sure but need to remove RTC so?

RTC is only used against the open PR's - this already got merged by me before you bought up this issue. If you just create a new PR to fix the broken behaviour that would be awesome :)

FYI, still couldn't find a reason for selecting the root node.

Maybe this is need in another part of Joomla (this is a helper), so making modification in MenusHelper::getMenuLinks could lead to B/C, adding another function is a better way or just handle level 0 in module ?

Sorry for jumping in, but since this was my fault, i wanted to fix it asap.