? Success

User tests: Successful: Unsuccessful:

avatar nueckman
nueckman
15 Apr 2015

Even without an official PSR-2 adoption, it seems like Joomla agrees with most of the standard.

This patch fixes a few outliers for the following standard:

static MUST be declared after the visibility

avatar nueckman nueckman - open - 15 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 15 Apr 2015
Labels Added: ?
avatar mbabker
mbabker - comment - 15 Apr 2015

Can you undo the changes in libraries/vendor? Those should be a PR to the
Framework repo. Otherwise, this is fine to merge.

On Tuesday, April 14, 2015, Nils Rückmann notifications@github.com wrote:

Even without an official PSR-2 adoption, it seems like Joomla agrees with
most of the standard.

This patch fixes a few outliers for the following standard:

static MUST be declared after the visibility


You can view, comment on, or merge this pull request online at:

#6781
Commit Summary

  • CS - change static order

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#6781.

avatar nueckman
nueckman - comment - 15 Apr 2015

My bad. I thought i skipped them like leafo.

avatar mbabker mbabker - change - 15 Apr 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-04-15 01:50:13
avatar mbabker mbabker - close - 15 Apr 2015
avatar mbabker mbabker - reference | - 15 Apr 15
avatar mbabker mbabker - merge - 15 Apr 2015
avatar mbabker mbabker - close - 15 Apr 2015

Add a Comment

Login with GitHub to post a comment