User tests: Successful: Unsuccessful:
Even without an official PSR-2 adoption, it seems like Joomla agrees with most of the standard.
This patch fixes a few outliers for the following standard:
static
MUST be declared after the visibility
Labels |
Added:
?
|
My bad. I thought i skipped them like leafo.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-04-15 01:50:13 |
Can you undo the changes in libraries/vendor? Those should be a PR to the
Framework repo. Otherwise, this is fine to merge.
On Tuesday, April 14, 2015, Nils Rückmann notifications@github.com wrote: