Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6696] - Move inline script to template.js [isis]

? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
8 Apr 2015

Keep javascript in .js files

At the end of index.php in isis there is an inline script. We can do better than that: Put those lines in template.js!

Testing

Apply the patch go to admin area (isis should be the template)
Check that everything still in order!
Also check the options:
Collapse Administrator Menu
Display Header
Pinned Toolbar
and Status Module Position

B/C

NONE

79ef336 8 Apr 2015 avatar dgt41 init
avatar dgt41 dgt41 - open - 8 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 8 Apr 2015
Easy No ⇒ Yes
avatar joomla-cms-bot joomla-cms-bot - change - 8 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 8 Apr 2015
Category ⇒ JavaScript Templates (admin)
ebe0443 8 Apr 2015 avatar dgt41 CS
avatar dgt41 dgt41 - change - 8 Apr 2015
The description was changed
avatar n9iels
n9iels - comment - 8 Apr 2015

@test works fine for me, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6696.
avatar n9iels n9iels - test_item - 8 Apr 2015 - Tested successfully
avatar RickR2H
RickR2H - comment - 10 Apr 2015

@test Test works for me.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6696.

avatar zero-24 zero-24 - change - 10 Apr 2015
Status Pending ⇒ Ready to Commit
avatar RickR2H RickR2H - test_item - 10 Apr 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 10 Apr 2015

RTC Thanks for testing :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6696.

avatar zero-24
zero-24 - comment - 10 Apr 2015

and coding @dgt41 :+1:

avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 10 Apr 2015
Labels Added: ?
avatar phproberto phproberto - change - 21 Apr 2015
Milestone Added:
avatar dgt41
dgt41 - comment - 5 May 2015

@phproberto Can I ask to re evaluate the decision for 3.5?
The reason for that request is that this PR solves #5970

avatar dgt41 dgt41 - change - 5 May 2015
Milestone Removed:
avatar dgt41 dgt41 - change - 6 May 2015
Milestone Removed:
avatar dgt41 dgt41 - change - 6 May 2015
Milestone Removed:
avatar zero-24 zero-24 - close - 28 May 2015
avatar wilsonge
wilsonge - comment - 28 May 2015

Merged into 3.5 development - sorry but I agree with Roberto in this case. (FWIW I suspect it's likely 3.5 will be the next release anyhow)

avatar wilsonge wilsonge - change - 28 May 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-05-28 23:35:17
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 28 May 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment