[#6673] - Fix for #6661. Module Manager/Hathor. Reset filters Position, Language and Type when filter Client changes.
- Closed
- 8 May 2015
- Medium
- Build: staging
- # 6673
- Diff
- bertmert:patch-9
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue #6661
Test:
- Current staging.
- Extensions > Module Manager
- Select "Site" as Client to see frontend modules.
- Select Position "atomic-bottomleft".
- Select Language: "All"
- Select now "Administrator" as Client to see backend modules.
- Message "There are no modules matching your query"
- See Position filter field: "- Select Position-". That's confusing.
- See Language filter field: Still "All"
- Click cross next to Search filter to reload page. All OK afterwards.
LOG OUT, LOG IN! to clear user session. Then apply patch. Or vice versa.
After patch:
- Filters for Position and Type are resetted correctly when Client changed. Also in the background.
- Message "There are no modules matching your query" only if other filters like State or Language don't match.
You see modules of newly selected client immediately. There's no need to reload page.
Test also in template Hathor!
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Administration JavaScript |
@test Could recreate problem, patch works as described. I agree that it looks nicer if language filter is reset as well.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6673.
@test Patch is working correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6673.
| Title |
|
||||||
Setting to RTC - thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6673.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
I have removed the RTC label for now, because I do agree with @crommie and @larapetersen that the language filter should be reset as well. If I set it to English for example, changing to Administrator also gives me no results. Resetting all search filters, will give you all modules and you can filter from there on.
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Removed:
?
|
||
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-03 02:26:04 |
| Closed_By | ⇒ | bertmert |
| Status | Closed | ⇒ | New |
| Closed_Date | 2015-05-03 02:26:04 | ⇒ | |
| Closed_By | bertmert | ⇒ |
Added reset for #filter_language. I coudn't test it (crashed my test environment somehow).
| Title |
|
||||||
This does not work here and I do not understand how anyone could test it correctly.
This is for Hathor, not Isis.
The issue is not related to this PR. It happens here without this change
I never can get the Site modules when using Hathor (as we have to click on Submit) if the client was set to Administrator in Isis before I switched to Hathor
If I set the filter on Site and let all filters set to Select ... or choose something in any filter, when I click on Submit, the Client changes to Administrator as it was set to Administrator in Isis before switching to Hathor.
If, in the contrary, I set in Isis the client to Site, then I never can display the Administrator client modules in Hathor.
To be sure of this test. I set the template to Hathor, then quitted joomla and deleted the cookie, then logged again: I never could get the administrator modules to display as, per default, the client is site.
Better correct that bug first imho.
PS: Related, needs a small PR: #filter_language is missing for Isis
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_modules/layouts/joomla/searchtools/default/bar.php#L18
@brianteeman @roland-d @infograf768 I've closed this PR because of #6682 (comment) Some code parts of 6682 are related to this issue here. I don't find a way at the moment to solve all conflicts. I'm too confused about Hathor specifics,,,
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-08 12:05:45 |
| Closed_By | ⇒ | bertmert |
Tested according to instructions. All filters are reset, except Language filter, shouldn't that be reset as well?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6673.