Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6641] - Menu Items Manager: status tips don't show for System Links

? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
3 Apr 2015

Before patch, mouse over the status icons for the url, alias, separator and heading menu items: the tip does not display because $tip was set to false

After patch:
screen shot 2015-04-03 at 11 45 50
screen shot 2015-04-03 at 11 45 28
screen shot 2015-04-03 at 11 45 18
screen shot 2015-04-03 at 11 45 09

avatar infograf768 infograf768 - open - 3 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2015
Labels Added: ?
avatar infograf768 infograf768 - alter_testresult - 3 Apr 2015 - fontanil: Tested successfully
avatar dneukirchen
dneukirchen - comment - 3 Apr 2015

confirm issue.
@test successful

avatar fontanil
fontanil - comment - 3 Apr 2015

@test
Patch works for me

avatar infograf768 infograf768 - change - 3 Apr 2015
Status Pending ⇒ Ready to Commit
avatar infograf768 infograf768 - alter_testresult - 3 Apr 2015 - dneukirchen: Tested successfully
avatar zero-24 zero-24 - change - 3 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - alter_testresult - 3 Apr 2015 - dneukirchen: Tested successfully
avatar zero-24 zero-24 - change - 3 Apr 2015
Category ⇒ Templates (admin) UI/UX
avatar infograf768
infograf768 - comment - 3 Apr 2015

Folks, let's wait for that one. We have an issue when the item is trashed. In that case the trashed state being -2, when added to the default # for the array, it gives a wrong tip.

I can see also that, even before the patch, when filtering by trashed state, these System links do not display when filtering by Trashed.

The code responsible is:

$query->select(
            'CASE a.type' .
                ' WHEN ' . $db->quote('component') . ' THEN a.published+2*(e.enabled-1) ' .
                ' WHEN ' . $db->quote('url') . ' THEN a.published+2 ' .
                ' WHEN ' . $db->quote('alias') . ' THEN a.published+4 ' .
                ' WHEN ' . $db->quote('separator') . ' THEN a.published+6 ' .
                ' WHEN ' . $db->quote('heading') . ' THEN a.published+8 ' .
                ' END AS published'
        );
        $query->from($db->quoteName('#__menu') . ' AS a');

I guess we have to find a complete solution for both issues.
@zero-24
please take of RTC

avatar infograf768 infograf768 - change - 3 Apr 2015
Status Ready to Commit ⇒ Pending
avatar wilsonge wilsonge - change - 3 Apr 2015
Labels Removed: ?
avatar infograf768
infograf768 - comment - 4 Apr 2015

Please test again.
Now the system links menu items get a new tip when trashed ("Publish menu item") as well as the right trash icon.

This PR includes #6629

avatar fontanil
fontanil - comment - 4 Apr 2015

@test: icons and tooltips are now OK

avatar Fedik
Fedik - comment - 4 Apr 2015

test works good for me

avatar infograf768 infograf768 - change - 4 Apr 2015
Status Pending ⇒ Ready to Commit
avatar Fedik Fedik - test_item - 4 Apr 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 4 Apr 2015

seting back to RTC. Thanks for testing.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6641.
avatar zero-24 zero-24 - change - 4 Apr 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 4 Apr 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-04-04 12:45:12
avatar wilsonge wilsonge - close - 4 Apr 2015
avatar wilsonge wilsonge - reference | - 4 Apr 15
avatar wilsonge wilsonge - merge - 4 Apr 2015
avatar wilsonge wilsonge - close - 4 Apr 2015
avatar Bakual Bakual - close - 4 Apr 2015
avatar Bakual Bakual - change - 14 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment