Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6631] - html5fallback.js: remove aria-invalid on label if field is invalid. fix #6573

? Pending

User tests: Successful: Unsuccessful:

avatar vinespie
vinespie
1 Apr 2015

Removing "aria-invalid" attribute on label when input is not valid.
https://www.w3.org/WAI/GL/wiki/Using_Aria-Invalid_to_Indicate_An_Error_Field
fix #6573

Hi, with my fellow worker @vinespie we found a mistake are generate by html5fallback.js

example :
For the mod_login, when you go out of a field like username "html5fallback.js" generate a aria-invalid="false" in the label.

aria-invalid is not used for label.

avatar vinespie vinespie - open - 1 Apr 2015
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 1 Apr 2015
Category ⇒ JavaScript
avatar zero-24 zero-24 - change - 1 Apr 2015
The description was changed
avatar zero-24
zero-24 - comment - 1 Apr 2015

@vinespie can you fix also the compressed file? https://github.com/vinespie/joomla-cms/blob/staging/media/system/js/html5fallback.js

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.
avatar vinespie
vinespie - comment - 1 Apr 2015

No, I searched the compression tool used to joomla but I have not found. Can you give me a link / her name?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.
avatar vinespie
vinespie - comment - 2 Apr 2015

@zero-24 I added the correction in the compressed file
thank you for the help @Fedik

avatar crommie
crommie - comment - 10 Oct 2015

Could you please add step by step testing instructions?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.

avatar hans2103
hans2103 - comment - 10 Oct 2015

Need testinstructions

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.

avatar zero-24 zero-24 - change - 10 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 10 Oct 2015

@crommie @hans2103

how to test

first test
  • Use a Browser (like old IE)
  • go to a mod_login screen
  • see the sourecode of the Username field
  • see the aria-invalid="false"
  • apply the patch
  • see it is gone
seccond test
  • go to a mod_login screen
  • copy the sourecode into http://validator.w3.org/
  • see issue about the aria-invalid="false"
  • apply the patch
  • see it is gone
avatar zero-24 zero-24 - change - 10 Oct 2015
Labels Removed: ?
avatar matrikular matrikular - test_item - 24 Oct 2015 - Tested unsuccessfully
avatar matrikular
matrikular - comment - 24 Oct 2015

I have tested this item :red_circle: unsuccessfully on a104968

Either this has already been fixed or I'm missing something.

The html5fallback.js is present in the documents head on: index.php?option=com_users&view=login but there is no aria-attribute on the label. Tested with IE 8.0.7601

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.

avatar yvesh
yvesh - comment - 24 Oct 2015

@zero-24 we are a bit irritated about your test instructions here at PBF Munich, the patch is for the label and not the field!? (INPUT) But we couldn't reproduce it either with the windows machines here.

avatar zero-24
zero-24 - comment - 24 Oct 2015

Thanks @yvesh and @matrikular closing here.

avatar zero-24 zero-24 - change - 24 Oct 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-24 19:05:30
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 24 Oct 2015

Add a Comment

Login with GitHub to post a comment