[#6535] - Update layout login view (redo of #6432)
- Closed
- 26 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6535
- Diff
- n9iels:login-update
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is a redo of #6432 because of merge conflicts.
Please see that one for test instructions
The problem
I discovered that the alignment on the login page of isis is not 100% pixel perfect. The field are just a few pixels to width. Hower, on RTL languages the wrong alignment was very good visible. So this patch solves alignment problems on LTR and RTL languages. I also add the possibility to load the templates-rtl.css in the login-view.
Farther optimizations:
- font-set icon
icon-joomlainstead of .png icon for the Joomla! logo on bottom of the loginform - Full width login button
Before/after screenshots
LTR before
LTR after (very small difference on the right of the fields)
RTL before
RTL after
How to test this patch
- Confirm the before/after screenshots on a LTR language (English)
- Confirm 100% page width button and sharp Joomla! logo on bottom
- Change your language to a RTL language (Persion for example)
- Test step 2 and 3 again.
- Confirm the login layout is also good shown on mobile devices. Feel free to use the Google Chrome F12 developer tools for this part
Notes
- Also add some extra spaces for CS on some places
- As idea of @dgt41 the login button is full-width. Please let me know how you're thoughts are about that
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | RTL Templates (admin) |
roland-d
- | Rel_Number | 0 | ⇒ | 6432 |
| Relation Type | ⇒ | Pull Request for |
| Easy | No | ⇒ | Yes |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-26 12:58:08 |
Thanks!
| Labels |
Added:
?
|
||
Class btn-block is supposed to equalize the width of the button with the input fields above. Have you tried to clean the browser’s cache?
| Labels |
Removed:
?
|
||
Merging as original PR was already RTC