[#6432] - Update layout login view for isis
- Closed
- 22 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6432
- Diff
- n9iels:isis-login
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The problem
I discovered that the alignment on the login page of isis is not 100% pixel perfect. The field are just a few pixels to width. Hower, on RTL languages the wrong alignment was very good visible. So this patch solves alignment problems on LTR and RTL languages. I also add the possibility to load the templates-rtl.css in the login-view.
Farther optimizations:
- font-set icon
icon-joomlainstead of .png icon for the Joomla! logo on bottom of the loginform - Full width login button
Before/after screenshots
LTR before
LTR after (very small difference on the right of the fields)
RTL before
RTL after
How to test this patch
- Confirm the before/after screenshots on a LTR language (English)
- Confirm 100% page width button and sharp Joomla! logo on bottom
- Change your language to a RTL language (Persion for example)
- Test step 2 and 3 again.
- Confirm the login layout is also good shown on mobile devices. Feel free to use the Google Chrome F12 developer tools for this part
Notes
- Also add some extra spaces for CS on some places
- As idea of @dgt41 the login button is full-width. Please let me know how you're thoughts are about that
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | RTL Templates (admin) |
Good idea! I think I like it, what about you?
I also edit the test instructions :-)
oops, looks like something went wrong...
Can somebody help me solve the merge conflicts when testing is done?
@n9iels I can help you with that, no problem.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6432.
@test I have reproduced the problem, and this patch does fix it!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6432.
@test OK - tested with Hebrew and Persian in Firefox and IE.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6432.
thanks for testing - setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6432.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Sorry you're going to need to merge in staging again here. There are still conflicts!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-22 08:44:39 |
| Rel_Number | 0 | ⇒ | 6535 |
| Relation Type | ⇒ | Related to |
@credenceweb @dgt41 @matrikular can you please test #6535? Or can @brianteeman set that PR to RTC because it is exactly the same code for a new version of the template css?
| Labels |
Removed:
?
|
||
Nice one @n9iels
Do you think you could also change the button to be
btn-blockor in plain english side to side? Just a thought