? Success
Pull Request for # 5966

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
21 Mar 2015

This should try and get the right element name for a files extension type (such as the Joomla package). As is, the $extension that gets fed into the doLoadLanguage() method is files_ (at least with the Joomla package).

Testing

1) Provision 2 3.4.0 sites for quick testing
2) On site 1, do not apply the patch and install https://github.com/joomla/joomla-cms/releases/download/3.4.1-rc2/Joomla_3.4.1-rc2-Release_Candidate-Update_Package.zip via the Extension Manager; should see the language constant untranslated.
3) On site 2, apply the patch.
4) Install https://github.com/joomla/joomla-cms/releases/download/3.4.1-rc2/Joomla_3.4.1-rc2-Release_Candidate-Update_Package.zip via the Extension Manager; should have the translated message.

If you know of other files extensions, test them too.

avatar mbabker mbabker - open - 21 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2015
Labels Added: ?
avatar jessicadunbar
jessicadunbar - comment - 21 Mar 2015

Tested on a 3.4 and updated to 3.4.1 works successfully


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6532.
avatar jessicadunbar jessicadunbar - test_item - 21 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - change - 21 Mar 2015
Easy No Yes
avatar zero-24 zero-24 - change - 22 Mar 2015
Category Libraries
avatar brianteeman brianteeman - change - 23 Apr 2015
Rel_Number 0 5966
Relation Type Pull Request for
avatar zero-24 zero-24 - change - 15 May 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 15 May 2015

@test successful set to RTC now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6532.

avatar zero-24 zero-24 - test_item - 15 May 2015 - Tested successfully
avatar zero-24 zero-24 - change - 15 May 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 16 May 2015
avatar Bakual Bakual - change - 16 May 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-05-16 18:58:49
Closed_By Bakual
avatar Bakual Bakual - close - 16 May 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment