[#6528] - Make a proper string to display the PHP version check
- Closed
- 25 May 2015
- Medium
- Build: staging
- Easy Test
- # 6528
- Diff
- mbabker:installMinimumPhpString
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
There's a string in the InstallationModelSetup class to display what translates into "PHP Version >= 5.3.10" in the installer that is manually appending the ">= 5.3.10" part to the translated string. This PR makes a new language string that puts the whole thing together using sprintf to inject the PHP version.
Test Instructions
Make sure the string still displays in the installer and there aren't any parse errors.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
wilsonge
- | Milestone |
Added: |
||
Is there a benefit to doing it this way over simply moving the >= into the current string
INSTL_PHP_VERSION="PHP Version >="
$option->label = JText::_('INSTL_PHP_VERSION') . '5.3.10';
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6528.
@brianteeman That still forces the version number to be at the end of the output. By making it a sprintf, a language string could show the translated version of "PHP 5.3.10 or later" instead of being forced to be worded so the version is at the end of the text.
@sovainfo The constant is already in use in this same line of code in that PR, whichever of these two are accepted first (assuming either are) will cause the other to need an update.
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Installation Language & Strings |
As this is a change in installation ini and we have issues with pagination which may require a fast 3.4.2 release, I guess we should wait to merge this as it is unlikely all TTs will be able to update their inis in a short notice.
A temporary solution could be to check if the new constant is present in the language and if not use the former one for now.
Otherwise, evidently, en-GB will take over.
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
Unless 3.4.2 is coming like tomorrow, any reason this needs to keep waiting for 3.4.3?
@test successful.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6528.
Bakual
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-25 00:55:22 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Good for RTL and languages generally speaking as they can place the variable the way they like.
For 3.4.2 I guess.