? Success

User tests: Successful: Unsuccessful:

avatar Mathewlenning
Mathewlenning
21 Mar 2015

Removed a nested switch if/else construct the from JCacheStorageCachelite::clean method.

There is more that can be done here, but baby steps are better than buggy steps.

avatar Mathewlenning Mathewlenning - open - 21 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 22 Mar 2015
Category Libraries
avatar zero-24
zero-24 - comment - 22 Mar 2015

@Mathewlenning can you update your PR? Github thinks we have merge conflicts


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6527.
avatar Mathewlenning
Mathewlenning - comment - 22 Mar 2015

How do I identify where a merge conflict could possibly be coming from?

avatar zero-24
zero-24 - comment - 22 Mar 2015

@Mathewlenning Now all is ok github is happy with you :)

How do I identify where a merge conflict could possibly be coming from?

hmm i don't know maybe @roland-d can help here?

avatar Mathewlenning
Mathewlenning - comment - 22 Mar 2015

I think I figured it out the hard way. I just went to the folder in the Joomla repository and checked the history of the class.

@roland-d I'm hoping you know a better way =^P

avatar roland-d
roland-d - comment - 23 Mar 2015

@Mathewlenning @zero-24 To see merge conflicts you can click on the Details link. I assume you can see that as well :)
gh_status

avatar Mathewlenning
Mathewlenning - comment - 24 Mar 2015

@roland-d thanks but it seem like I can only see the details button on pull requests that can be automatically merged. This is what it looks like when there is a conflict

merge_conflicts

avatar roland-d
roland-d - comment - 24 Mar 2015

@Mathewlenning Aha, that I didn't know. Someone with access will have to post the conflicts then.

avatar mbabker
mbabker - comment - 24 Mar 2015

You can't see the conflicts via the GitHub UI. If you're running git from a command line the easiest way is to fetch the current staging branch and merge it to your branch; git will show any conflicts. FWIW, I see a "Merge pull request" button right now and no conflicts notice.

avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. I will close this PR now. If you want to update your PR, then this can be re-opened.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6527.

avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-08 09:40:58
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016

Add a Comment

Login with GitHub to post a comment