Pending

User tests: Successful: Unsuccessful:

avatar aleks-linya aleks-linya - open - 14 Jan 2013
avatar ndeet
ndeet - comment - 17 Jan 2013

Works very well on J! 3.0.2. Thank YOU very much for fixing this.

avatar infograf768
infograf768 - comment - 18 Jan 2013

Looks like we have twice the block starting with
/*
* Search and fix derivatives of link code * >email@email.com. This happens when inserting an email in TinyMCE, cancelling its suggestion to add
* the mailto: prefix...
*/
It seems that Tiny does not do that anymore.
Shall we not at least get rid of the duplicate?
Otherwise looks good.

avatar infograf768
infograf768 - comment - 18 Jan 2013

We have updated core for codestyle issues.
This PR does not apply anymore.
Can you update?

avatar aleks-linya
aleks-linya - comment - 18 Jan 2013

Codestyle issues:
I fixed some codestyle issues. But codesniffer still shows me a lot of errors, not only in my code but also in the old one. Is it right? Or am I doing something wrong?

Code duplication:
You refer to the blocks of code from 119 to 133 and from 140 to 154 lines?
Yes, these blocks differ only by two lines, but they are consistent with the rest of the code.

By the way, why this issue has pending status on tracker? Shouldn't it have confirmed status?

avatar infograf768
infograf768 - comment - 19 Jan 2013

pending means that there is a patch and that it is ready to test.
Please add your comments on tracker if you want this to be tested.

This PR is NOT updated to the present state of the file in master and can't be merged/tested.
You first have to update your fork and update the PR or create a new one.

avatar aleks-linya aleks-linya - close - 19 Jan 2013
avatar elkuku
elkuku - comment - 19 Jan 2013

See ⇒ #666 :wink:

Add a Comment

Login with GitHub to post a comment