[#649] - Fixing extension install from dynamic URLs
- Closed
- 8 Feb 2013
- Medium
- Build: master
- # 649
- Diff
- Bakual:patch-6
User tests: Successful: Unsuccessful:
Since the JInstallerHelper::downloadPackage() function now uses JHttpFactory::getHttp() instead of stream_get_meta_data(), the "Content-Dispositon" data is now stored directly in $response->headers['Content-Disposition'] instead of $response->headers['wrapper_data']['Content-Disposition'].
Currently in Joomla 3.0.2, you can't install extensions directly from an URL if the URL points to a dynamic created link with URL parameters (like in Akeeba Release System or CTransifex). This is because it doesn't detect a valid filename.
This commit fixes this.
Just wanted to note that the platform merged the PR. Wouldn't it make sense to merge this PR as well then?
Fixed with eclipse. Thanks.
Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29946
PR on platform: joomla/joomla-platform#1795
I did it on both repos because it's unclear where the proper place is. The file got moved to /libraries/legacy in current platform master since the one used in Joomla 3.0.2 where it's in /libraries/joomla.
Thread on GoogleGroups: https://groups.google.com/d/topic/joomla-dev-platform/kkBVeh0wygw/discussion