User tests: Successful: Unsuccessful:
Fixes a javascript error, which occurs when you change the name attribute of the first field in a repeatable field type fieldset.
Install the simple Repeatable FormField Demo Template. It is just a simple Template with the repeatable formfield type.
Go to Extension > Template Manager > Styles > repeatable - Default.
Go to the Advanced Settings Tab. Click on the "Select" Button. You should see the repeatable form field modal window with some default values.
Open templates/repeatable/templateDetails.xml and change the value of the name attribute of the first field in the repeatable fieldset from "fieldA" to another value (e.g "fieldX")
Now go again to Extensions > Template Manager > Styles > repeatable - Default.
Go to the Advanced Settings Tab und try to open the modal window again (click on the button).
The modal window shows up.
The values of the field you changed the name of should be empty.
A javascript error occurs and you get back to the template styles overview page.
Labels |
Added:
?
|
Easy | No | ⇒ | Yes |
Category | ⇒ | JavaScript |
Status | Pending | ⇒ | Ready to Commit |
Two successful tests, moving to RTC.
Thanks David for your very first core contribution! Well done :)
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 16:15:05 |
Labels |
Removed:
?
|
I can confirm this
And the pull fix the problem