? Success

User tests: Successful: Unsuccessful:

avatar dneukirchen
dneukirchen
14 Mar 2015

Fixes a javascript error, which occurs when you change the name attribute of the first field in a repeatable field type fieldset.

Steps to reproduce the issue / Testing instructions

Install the simple Repeatable FormField Demo Template. It is just a simple Template with the repeatable formfield type.

Go to Extension > Template Manager > Styles > repeatable - Default.

Go to the Advanced Settings Tab. Click on the "Select" Button. You should see the repeatable form field modal window with some default values.

Open templates/repeatable/templateDetails.xml and change the value of the name attribute of the first field in the repeatable fieldset from "fieldA" to another value (e.g "fieldX")

Now go again to Extensions > Template Manager > Styles > repeatable - Default.

Go to the Advanced Settings Tab und try to open the modal window again (click on the button).

Expected result

The modal window shows up.
The values of the field you changed the name of should be empty.

Actual result

A javascript error occurs and you get back to the template styles overview page.

avatar dneukirchen dneukirchen - open - 14 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 14 Mar 2015
Easy No Yes
avatar zero-24 zero-24 - change - 14 Mar 2015
Category JavaScript
avatar Fedik Fedik - test_item - 15 Mar 2015 - Tested successfully
avatar Fedik
Fedik - comment - 15 Mar 2015

I can confirm this :bug:

And the pull fix the problem

avatar waader
waader - comment - 15 Mar 2015

@test works as described, thanks!

avatar SniperSister SniperSister - change - 15 Mar 2015
Status Pending Ready to Commit
avatar waader waader - test_item - 15 Mar 2015 - Tested successfully
avatar SniperSister
SniperSister - comment - 15 Mar 2015

Two successful tests, moving to RTC.

Thanks David for your very first core contribution! Well done :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6429.
avatar brianteeman brianteeman - change - 15 Mar 2015
Labels Added: ?
avatar mbabker mbabker - close - 15 Mar 2015
avatar mbabker mbabker - reference | - 15 Mar 15
avatar mbabker mbabker - merge - 15 Mar 2015
avatar mbabker mbabker - close - 15 Mar 2015
avatar zero-24 zero-24 - close - 15 Mar 2015
avatar mbabker mbabker - change - 15 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-15 16:15:05
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment