? Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
14 Mar 2015

This replaces #5647

Description

This allows you to use spaces to separate values of some com_media options:

  • Legal Extensions (File Types)
  • Legal Image Extensions (File Types)
  • Ignored Extensions
  • Legal MIME Types
  • Illegal MIME Types

radek-whitespaces

How to test

After applying the patch:

  • Ensure that values without spaces still work as expected.
  • Add values including spaces between them and test that all the settings still work.

Backwards compatibility issues

This should be 100% backward compatible.

avatar phproberto phproberto - open - 14 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2015
Labels Added: ?
avatar compojoom
compojoom - comment - 14 Mar 2015

works as expected for me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar compojoom compojoom - test_item - 14 Mar 2015 - Tested successfully
avatar lunalars
lunalars - comment - 14 Mar 2015

tested with and without spaces: works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar lunalars lunalars - test_item - 14 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2015

Setting RTC - thanks for testing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar Mumion
Mumion - comment - 14 Mar 2015

I tested it local (Win7; xampp v3.2.1.; PHP Version 5.6.3), and get an error, when i took the spaces in the field-> Legal Extensions (File Types). The other fields works with spaces. The field-> Legal Extensions (File Types needs before and after a ","


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar brianteeman
brianteeman - comment - 14 Mar 2015

Unsetting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Ready to Commit Pending
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Removed: ?
avatar compojoom
compojoom - comment - 14 Mar 2015

@Mumion - can you post the values that you have in Legal Extensions. I had another look at this and I can't reproduce your issue.

avatar lunalars
lunalars - comment - 14 Mar 2015

checked "Legal Extensions (File Types)" again ...
" bmp , csv,doc,gif,ico, jpg , jpeg ,odg, "
works fine on php 5.5.9-1ubuntu4.6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar seagul30
seagul30 - comment - 14 Mar 2015

works fine for me.
cannot reproduce problem of @mumion
Tested fields:
Legal Extensions (File Types)
Legal Image Extensions (File Types)
Ignored Extensions
Legal MIME Types

Illegal MIME Types

with different kind of blanks before and after comma


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar seagul30 seagul30 - test_item - 14 Mar 2015 - Tested successfully
avatar seagul30
seagul30 - comment - 14 Mar 2015

I came across the following setup issue:
in com_media global options the field "Legal Image Extensions (File Types)" has the values: bmp,gif,jpg,png
In my opinion the value "jpeg" is missing.

In Template global options you are allowed to upload gif,bmp,jpg,jpeg,png

I don't know if there are any other places of this setup.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar seagul30 seagul30 - test_item - 14 Mar 2015 - Not tested
avatar Mumion
Mumion - comment - 14 Mar 2015

Field: "Legal Extensions (File Types)

bmp,csv,doc,gif,ico jpg jpeg odg,odp,ods,odt,pdf png ppt,swf,txt,xcf,xls,BMP,CSV,DOC,GIF,ICO,JPG,JPEG,ODG,ODP,ODS,ODT,PDF,PNG,PPT,SWF,TXT,XCF,XLS
-> with this pamrameters i get the notice: Dieser Dateityp wird nicht unterstützt. (This file type is not supported.)

When i change in this:
bmp,csv,doc,gif,ico,jpg,jpeg,odg,odp,ods,odt,pdf,png,ppt,swf,txt,xcf,xls,BMP,CSV,DOC,GIF,ICO,JPG,JPEG,ODG,ODP,ODS,ODT,PDF,PNG,PPT,SWF,TXT,XCF,XLS
-> its works fine.

The other fields works with spaces. I use the german translation pack, but i test also with the english translation.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar Mumion Mumion - test_item - 14 Mar 2015 - Tested unsuccessfully
avatar Mumion
Mumion - comment - 14 Mar 2015

I tested with a .jpg and .png file.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar Mumion
Mumion - comment - 14 Mar 2015

The fields:
Legal Image Extensions (File Types)
[Ignored Extensions (not tested)]
Legal MIME Types
Illegal MIME Types

works with spaces and without a patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar compojoom
compojoom - comment - 14 Mar 2015

Well, the fix doesn't handle he case when you don't enter any commas. It only fixes the issue when you have commas and spaces.
Entering file names without a comma is something that can't work. As the description of the field says (comma separated).

avatar Mumion
Mumion - comment - 14 Mar 2015

Ok, i misunderstood this.

Now, the patch works fine.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar Mumion Mumion - test_item - 14 Mar 2015 - Tested successfully
avatar Mumion Mumion - test_item - 14 Mar 2015 - Tested successfully
avatar hmalma
hmalma - comment - 14 Mar 2015

I tested with:

XAMPP v3.2.1, Joomla!-Version 3.4.1-dev, with blank before jpg as shown in the pic attached.screen shot 2015-03-14 at 07 59 11

Result with patch: screen shot 2015-03-14 at 08 05 13

Result without patch: screen shot 2015-03-14 at 08 10 54
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.

avatar hmalma hmalma - test_item - 14 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Mar 2015

Based on retests I am marking this RTc again


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6419.
avatar brianteeman brianteeman - change - 14 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 14 Mar 2015
Labels Added: ?
avatar zero-24 zero-24 - close - 14 Mar 2015
avatar mbabker mbabker - change - 14 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 15:26:25
avatar mbabker mbabker - close - 14 Mar 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment