Great job! Will do some testing

@chrisdavenport @infograf768 Can I humble ask for some input or some testing here?
Both of you have a deep understanding how this component work and have a nice testing env, so I will be extremely thankful if you can spare some time for this!

small note:
such big list not very friendly (maybe somehow can make multi columns, or something), and "toggle selection" that near each checkbox, very confuse:

@Fedik multicolumn or scrollable fixed height will be a better fit here?

@dgt41 not sure what can be a good solution here, but I hate scroll to much
multicolumn was a quick idea, but also no idea how it will be

@Fedik A table style layout is quite hard to be imposed here, as we don’t know the possible width of the every column e.g. a label with some title "something really large to accommodate"
This means we either hardcode some widths with the possibility that some columns might need some scrolling in x-axis or we hardcode some max-height and then we have some y-axis scrolling.
Or something else? Someone front end expert here?

@losedk Can you test this one?

@dgt41 Just did some testing:

• The show all button doesn't expand the accordions
• The toggle selection button only selects the first radio button

Perhaps the Toggle Selection button above the accordion should be renamed to Select all filters?

@losedk which of the two toggle buttons is not working? (the one above the accordion or the one in each slide?)
Yes Toggle selection should be renamed to something more descriptive.
The show all button seems to toggles the state, thus the behavior is kinda weird. If first slide open this will be closed and all others will become open. I have to find a work around for this...

@dgt41 The one above the accordion.

Just tried again. The show all button does work, but when initially clicking, the first group is collapsed and the others are expanded.

Thank you @losedk for the input! Now all should be fixed! I guess I should have tested this with some real data

Hi, i tested the patch and it works.

I have 2 suggestions:

• The "Show All" could toogle to "Hide All"
• What Do you think about the number of items behind the Titel of the toogle box. For example "Search by Author (3)"

@patjun Thanks for testing

The button’s function is not toggling all the panels to shown on hidden, is just opening all the panels. The problem is that BS 2.3.2 has same defects here and this is the easiest approach here. But we can make a function to implement this functionality, if people think that this is essential. Bear in mind that as it is right now the code is 1 line, inline in the onClick of a button, very simple implementation…

The count is something that can be easily implemented, will push that in a few minutes...

Hello! The "Show all" only opens the first panel.

@designbengel Thanks, it should be fine now

Yes, now it´s ok

Hi,
i tested the patch again. The numbers in the toggle box are perfect, but i still get problem with the "Show all" Button.

What i did:

• Open my Filter
• Open Catergory Section -> close Category Section
• Open Country Section -> close Country Section
• Click "Show all"

Then i get this. All Section are open except the two Categories i opened and closed before. Here is a screenshot.

Thanks
Patrick

@patjun Thanks Patrick for testing!
I made some changes to incorporate a bulletproof solution for expanding collapsing the accordion. It looks like this:

On loading the page:

On clicking on Expand all slides button on the right top corner

And then on clicking on Collapse all slides

This should solve the misbehaving button!

@test played arround using the filters. Patch seems to work.

@test nearly there. Looks good in the frontend. In the backend however if there are no indexed items and you try to create a new search filter (yes I know super unlikely but....) then the buttons still show

and actually by clicking on "Expand All" the view starts to fall apart :P

However other than that one weird test case things look good :) Nice work!!

I totally missed the front end module, but it should be fine now:

@wilsonge shall I hide the buttons when items aren't indexed?

In the backend for the stuff we discussed yes. In the frontend it's really weird. I'd leave it for another PR - because really we probably shouldn't render the module at all or something

A Notice Message would be great for the user - if nothing is indexed -> the search module reports that nothing will be shown then. Same for not enabled plugin...

It's way outside the scope of this PR tho. Let's get that backend stuff fixed @dgt41 that we talked about at JAB (adding that method into the model) then lets get this tested and merged

@wilsonge done!

#7140

The filters are overflowing now at the bottom - didn´t found out why yet.

@designbengel I was doing something stupid (inline styling) that’s why you got overflowing modules. Can you retry with the new code?

@dgt41 yes great! now it´s fine - and the other stuff i tested long before successfully :)

@test All works as described. The module also fits correctly.

@dgt41 The map count in the backend, would be nice if it is updated on-the-fly as items are checked/unchecked. Can you have a look at that?

@roland-d it’s fairly easy, but shall i do it in another PR so we can go ahead and merge this?

@dgt41 Sounds good to me.

@dgt41 No - sorry now i tested the other stuff as well and The "Expand all" Button doesn´t expand all.
When expanding some slides are closed. When open slides manually some remain open, some not. Strange behaviour...

@dgt41 would be great for UX if the checkboxes would check also by clicking on the label. Is that possible?

@dgt41 I can confirm the findings by @designbengel. As for the suggestion for clicking the label, that is a good enhancement.

@designbengel @roland-d what browser?

@dgt41 FF 38.0.5 on Windows 8.1 in my case.

@roland-d can’t replicate it here! can you give me some more info how this is failing?

@dgt41 While I was writing the instructions I can't reproduce it anymore :) Perhaps it was a cache issue. Sorry for the trouble ;)

@roland-d haha spooky code ????
I guess if also @designbengel can confirm that this is a cache problem we can move it to rtc
And make all other improvements in another PR

My Browser: Safari 8.0.5 / O SX
cleared the cache -> it worked
Played arround with toggle on/off close/open slides and then the expand all didn´t worked anymore...

@designbengel fixed it

tested successfully

RTC Thanks for testing and coding here

@dgt41 Can you please fix the conflicts so we can go ahead and merge it? Thank you.

@roland-d done!

@dgt41 Not having much luck today ;) Now Travis throws a fit:

FILE: ...s/build/joomla/joomla-cms/components/com_finder/helpers/html/filter.php

--------------------------------------------------------------------------------

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

--------------------------------------------------------------------------------

 372 | ERROR | Please consider a blank line preceding your comment

@roland-d Travis is happy now with the last commit. ;)

@dgt41 Sorry to bother this PR further but I would like to ask some more questions. In your images I see your front-end view gives bootstrapped dropdowns, I don't get them. They are regular dropdowns, is that supposed to be the case?

Second is concerning the backend, when creating a filter, you build the according sliders, inside the slider is the content. The sample data has 24 catgories, there is so much whitespace between each entry that the list gets pretty long. Now imagine on a site with many more categories, that means a scroll craze. Can you have a look at reducing the spacing between each item?

@roland-d front end select tags have no bootstrap touches (the preview is safari browser and should be different in each browser). We could apply chosen there to modify the look and feel but I wouldn’t recommended for the front end. For the input tags inside of the slider a simple css addition should fix the spacing. By the way, which browser you’ve used to test this?

@dgt41 As for front-end, I agree, let's not touch it just was looking to understand the difference between your image and what I saw.

Backend, I am using Firefox on a Mac.

@roland-d It should be ok now

@dgt41 The input height is OK now. Even so, I think we may need to move to chozen at some point, as that is much friendlier with long lists, out of scope for this PR.

This has been merged into 3.5-dev with commit b3ac598 Thanks.