? Success
Pull Request for # 6212

User tests: Successful: Unsuccessful:

avatar Qlimax90
Qlimax90
27 Feb 2015

Hi everyone,

in /plugins/captcha/recaptcha/recaptcha.php from line 55 to 79, is there any reason why the new recaptcha is loading the mootools library? Especially on line 76 Mootools gets loaded by JHtml::_('script', $file, true, true);

#6212

avatar Qlimax90 Qlimax90 - open - 27 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 27 Feb 2015
Rel_Number 6212
Relation Type Pull Request for
avatar brianteeman brianteeman - change - 27 Feb 2015
Category JavaScript Plugins
avatar losedk
losedk - comment - 27 Feb 2015

Tested. All good

avatar losedk losedk - test_item - 27 Feb 2015 - Tested successfully
avatar losedk losedk - test_item - 27 Feb 2015 - Not tested
avatar losedk losedk - test_item - 27 Feb 2015 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 27 Feb 2015

The addScriptDeclaration is being injected before the addScript statement so would this not lead to undefined JS variables?

avatar losedk
losedk - comment - 27 Feb 2015

Is that a problem? addScript always injects into head

avatar dgt41
dgt41 - comment - 27 Feb 2015

@C-Lodder It would be nice to follow the actual chain of events, first the file and then the initialization :+1:

avatar Qlimax90
Qlimax90 - comment - 27 Feb 2015

hmm but this would cause a redundancy in the code :-1:

avatar losedk losedk - test_item - 27 Feb 2015 - Not tested
avatar wilsonge
wilsonge - comment - 27 Feb 2015

@C-Lodder The inline scripts are always added after the files so it's not an issue. That's why we load jQuery no captcha as a file rather than a script

avatar nueckman
nueckman - comment - 14 Mar 2015

Looks good

avatar kolvar kolvar - test_item - 14 Mar 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 6 Jun 2015

@test It works Ok, no mootools.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6218.

avatar anibalsanchez anibalsanchez - test_item - 6 Jun 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 6 Jun 2015

@dgt41 @Qlimax90 what is the status here? Can we leave it now as it is or need we to change something? As we get multible successful tests here :smile: Thanks.

avatar Qlimax90
Qlimax90 - comment - 6 Jun 2015

I think we can leave it as it is :)

avatar dgt41
dgt41 - comment - 6 Jun 2015

@Qlimax90 just do a merge on staging to resolve the conflicts

avatar Qlimax90
Qlimax90 - comment - 7 Jun 2015

@dgt41 It seems that i have not the rights to do this?
"This pull request contains merge conflicts that must be resolved.
Only those with write access to this repository can merge pull requests."

avatar dgt41
dgt41 - comment - 7 Jun 2015

@Qlimax90 if you pull rebase to latest staging in your local copy, solve the conflicts and push the code back to your online copy, everything should be ok!

avatar zero-24 zero-24 - change - 11 Jun 2015
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 11 Jun 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 7 Jul 2015

@Qlimax90 Will you update your PR or should I recreate it? I think that it is a good change (get rid of the loading of the Mootools framework). If you are still keen to do it, then please do it in the next days if possible! If you do it, then please also add a blank line after the switch statement. Thank you in advance!

avatar Qlimax90
Qlimax90 - comment - 8 Jul 2015

@dgt41 @Kubik-Rubik Please feel free to recreate, at the moment I am struggeling with the local copy due to the fact that I created the PR online. The local branch is not working, sorry...

avatar Kubik-Rubik Kubik-Rubik - change - 9 Jul 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar zero-24 zero-24 - close - 10 Jul 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 10 Jul 2015

Closed in favor of #7403. Thank you @Qlimax90 for your contribution!

avatar Kubik-Rubik Kubik-Rubik - change - 10 Jul 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-07-10 12:19:49
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 10 Jul 2015
avatar zero-24 zero-24 - change - 10 Jul 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment