? Success

User tests: Successful: Unsuccessful:

avatar peterlose
peterlose
26 Feb 2015

Before PR

skaermbillede 2015-02-26 kl 19 47 53

After PR

skaermbillede 2015-02-26 kl 19 48 05

avatar losedk losedk - open - 26 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 27 Feb 2015

@test works fine, good change!
Please add some code style and remove empty lines

95d808b 27 Feb 2015 avatar CS
avatar losedk
losedk - comment - 27 Feb 2015

@n9iels is it better now?

avatar C-Lodder
C-Lodder - comment - 27 Feb 2015

Nice one.

Just a thought. Would it not be better to use Bootstrap alert boxes instead of an accordion?

avatar zero-24
zero-24 - comment - 27 Feb 2015

@losedk i have just add a CS PR against your repo ;) looks cool :smile:

avatar losedk losedk - reference | - 27 Feb 15
avatar losedk
losedk - comment - 27 Feb 2015

@zero-24 thanks alot! Merged :)

avatar zero-24
zero-24 - comment - 27 Feb 2015

@losedk just tested:

Notice: Undefined variable: i in JRoot/administrator/components/com_installer/views/warnings/tmpl/default.php on line 30

I don't know why we need the $i there?

avatar n9iels
n9iels - comment - 27 Feb 2015

$i is not defined, it can be removed over here

avatar losedk
losedk - comment - 27 Feb 2015

@zero-24 fixed now. Could you test again?

avatar zero-24
zero-24 - comment - 27 Feb 2015

@test @losedk works good here. Thanks! One more tester here :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6200.
avatar zero-24 zero-24 - test_item - 27 Feb 2015 - Tested successfully
avatar zero-24 zero-24 - change - 27 Feb 2015
Easy No Yes
avatar zero-24 zero-24 - change - 27 Feb 2015
Category Administration UI/UX
avatar brianteeman brianteeman - change - 28 Feb 2015
Category Administration UI/UX Administration Templates (admin) UI/UX
avatar losedk
losedk - comment - 2 Mar 2015

@n9iels Could you test again?

avatar n9iels
n9iels - comment - 2 Mar 2015

@test works fine for me, thanks!
Two tests, moving to RTC!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6200.
avatar n9iels n9iels - test_item - 2 Mar 2015 - Tested successfully
avatar zero-24 zero-24 - change - 2 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 2 Mar 2015
Labels Added: ?
avatar nonumber
nonumber - comment - 4 Mar 2015

@losedk If you can/want: please also do this for the other admin components. Pretty much all of them use the old sliders.panel somewhere. These should all be converted to the bootstrap methods.

avatar losedk
losedk - comment - 4 Mar 2015

@nonumber can't seem to find others than in Hathor

avatar nonumber
nonumber - comment - 4 Mar 2015

You are correct. My mistake.

avatar phproberto phproberto - change - 7 Mar 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-03-07 04:05:01
avatar phproberto phproberto - close - 7 Mar 2015
avatar phproberto phproberto - close - 7 Mar 2015
avatar phproberto
phproberto - comment - 7 Mar 2015

Merged. Thanks!

Add a Comment

Login with GitHub to post a comment