[#6199] - Do we need to ship outdated postinstall messages for new installs?
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6199
- Diff
- zero-24:patch-10
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Hi,
atm we have all messages that was there on update also for new installs. As @mbabker correctly write here: #6195 (diff)
I think we don't need to ship it e.g. the robots.txt and htaccess changens for new installs.
This applys to 3 of our current messages :
EACCELERATOR (can't be used for 3.4 new installs as it is unsupported)
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1506
PHP Version Check (this will be checked by joomla bevor we can see the postinstall message if you use not the min PHP version you can't use joomla)
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1508
and
robots.txt and htaccess (if someone decide to use it from a new install they apply allready the last version)
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L1509
So I think we can we simple remove it from the installation SQL files. Any problems with it?
How to test
- Install my patch branche: https://github.com/zero-24/joomla-cms/archive/patch-10.zip
- Check the postinstall messages after clean install. There should be only the two factor and the welcome message.
joomla-cms-bot
- | Labels |
Added:
?
|
||
I am not 100% certain about this. The logic is good but that assumes that all new joomla sites are installed with our installer. Unfortunately many hosts have their own installation scripts which do not perform any pre-installation checks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6199.
@brianteeman if the PHP Version don't match (pre checked or not) we never had a chance to see the post install message as we exit with the first line of our code here:
https://github.com/joomla/joomla-cms/blob/staging/index.php#L9-12
https://github.com/joomla/joomla-cms/blob/staging/administrator/index.php#L9-12
So we never open the administrator or the site than. 
True - I thought this was the magic quotes message - my mistake for not
looking
On 27 February 2015 at 08:22, zero-24 notifications@github.com wrote:
@brianteeman https://github.com/brianteeman if the PHP Version don't
match (pre checked or not) we never had a chance to see the post install
message as we exit with the first line of our code here:
https://github.com/joomla/joomla-cms/blob/staging/index.php#L9-12https://github.com/joomla/joomla-cms/blob/staging/administrator/index.php#L9-12
So we never open the administrator or the site than. [image:
—
Reply to this email directly or view it on GitHub
#6199 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration |
Fatal error: Class 'PatchTester\Model\JText' not found in /Applications/MAMP/htdocs/joomla-cms-staging/administrator/components/com_patchtester/PatchTester/Model/PullModel.php on line 168
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6199.
tested-its works
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6199.
| Status | Pending | ⇒ | Ready to Commit |
@designbengel:
this is a newinstallation. Because in an excisting installation the message is there. There is no other way to test ist.
It works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6199.
Moving to RTC based on testing
Fatal error: Class 'PatchTester\Model\JText' not found in /Applications/MAMP/htdocs/joomla-cms-staging/administrator/components/com_patchtester/PatchTester/Model/PullModel.php on line 168
This is a issue with com_patchtester and not with this patch.
Thanks for testing!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6199.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 09:04:26 |
Merged. Thanks!
Good point, new installs indeed do not need this message.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6199.