? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
26 Feb 2015

@infograf768 @brianteeman @Hackwar

Can you have a look here as it is a post install message for the multilanguage issue in 3.4.0. (see: #6194)
Expected the language strings maybe needs review.

Thanks :smile:

avatar zero-24 zero-24 - open - 26 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 26 Feb 2015

I would not use a fix button as "1" possibly will not exist on the site.
I would just ask users to save again their Content Languages.

avatar zero-24 zero-24 - change - 26 Feb 2015
The description was changed
avatar Bakual
Bakual - comment - 26 Feb 2015

I would not use a fix button as "1" possibly will not exist on the site.
I would just ask users to save again their Content Languages.

@zero-24 I agree with JM. I think you can instead set the action to redirect to the language manager. This way the user is at the right screen already and can easily change the language setting.

avatar zero-24
zero-24 - comment - 26 Feb 2015

@infograf768 @Bakual i have just removed the action. Thanks

19d2fc6 26 Feb 2015 avatar zero-24 CS
avatar zero-24
zero-24 - comment - 26 Feb 2015

Just added the string changes by @brianteeman and a link to the language manger.
New string:
COM_CPANEL_MSG_LANGUAGEACCESS340_BODY="Since Joomla 3.4.0 you may have issues with the language filter plugin on your web site. To fix it please open the Language Manager and fix the access settings for all the content languages manually."

avatar infograf768
infograf768 - comment - 26 Feb 2015

The point here is that the default access displays as if it was already saved when editing a Content Language.
Therefore I would slightly change the strings to

+COM_CPANEL_MSG_LANGUAGEACCESS340_TITLE="You have possible issues with your multilingual settings"
+COM_CPANEL_MSG_LANGUAGEACCESS340_BODY="Since Joomla 3.4.0 you may have issues with the System - Language Filter plugin on your web site. To fix them please open the <a href="_QQ_"index.php?option=com_languages&view=languages"_QQ_">Language Manager</a> and save each content language manually to make sure an access is saved."
avatar zero-24
zero-24 - comment - 26 Feb 2015

This will result into the following view to the user:
result_postinstall

avatar brianteeman
brianteeman - comment - 26 Feb 2015

I assume the screenshot is before the last changes

On 26 February 2015 at 09:57, zero-24 notifications@github.com wrote:

This will result into the following view to the user:
[image: result_postinstall]
https://cloud.githubusercontent.com/assets/2596554/6389658/4461feb6-bda6-11e4-9135-7a90e5fed878.JPG


Reply to this email directly or view it on GitHub
#6195 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 26 Feb 2015

@infograf768 your string is fine but needs one change at the end

to make sure an access is saved.
Needs to say Access level not just access

avatar infograf768
infograf768 - comment - 26 Feb 2015

fine

avatar zero-24
zero-24 - comment - 26 Feb 2015

Thanks @infograf768 zero-24@6c2504c

I assume the screenshot is before the last changes
@brianteeman yes this is the new one (with zero-24@6c2504c):

result_postinstall

avatar zero-24
zero-24 - comment - 26 Feb 2015

@brianteeman just appled the Access level fix: zero-24@3764f6d

:smile:

avatar infograf768
infograf768 - comment - 26 Feb 2015

@test
Looks fine here now

avatar infograf768 infograf768 - change - 26 Feb 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 26 Feb 2015
Easy No Yes
avatar infograf768 infograf768 - change - 26 Feb 2015
Labels Removed: ?
avatar zero-24 zero-24 - alter_testresult - 26 Feb 2015 - infograf768: Tested successfully
avatar zero-24 zero-24 - change - 26 Feb 2015
Category Administration
avatar zero-24
zero-24 - comment - 26 Feb 2015

how to test

  • install joomla
  • using e.g. com_patchtester to apply this patch
  • go on you database and run manually (replace the #__ with your prefix)
INSERT INTO `#__postinstall_messages` (`extension_id`, `title_key`, `description_key`, `action_key`, `language_extension`, `language_client_id`, `type`, `action_file`, `action`, `condition_file`, `condition_method`, `version_introduced`, `enabled`) VALUES
(700, 'COM_CPANEL_MSG_LANGUAGEACCESS340_TITLE', 'COM_CPANEL_MSG_LANGUAGEACCESS340_BODY', '', 'com_cpanel', 1, 'message', ', '', 'admin://components/com_admin/postinstall/languageaccess340.php', 'admin_postinstall_languageaccess340_condition', '3.4.1', 1);

avatar zero-24
zero-24 - comment - 26 Feb 2015

Thanks @mbabker i have just removed the postinstall for new installs, that should not have the problem.

avatar Kubik-Rubik
Kubik-Rubik - comment - 27 Feb 2015

Thank you @zero-24 for the good contribution!

avatar Kubik-Rubik Kubik-Rubik - change - 27 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-27 11:00:33
avatar Kubik-Rubik Kubik-Rubik - close - 27 Feb 2015
avatar Kubik-Rubik Kubik-Rubik - reference | - 27 Feb 15
avatar Kubik-Rubik Kubik-Rubik - merge - 27 Feb 2015
avatar Kubik-Rubik Kubik-Rubik - close - 27 Feb 2015
avatar Hils
Hils - comment - 27 Feb 2015

Joomla has a lot of '!' - we should be consistent and remove most of them.

avatar Kubik-Rubik
Kubik-Rubik - comment - 27 Feb 2015

@Hils Please do a PR with the correction. Thanks! (or @zero-24 :-) )

avatar Hils
Hils - comment - 27 Feb 2015

Will do - sorry I missed the merge!

avatar zero-24 zero-24 - head_ref_deleted - 27 Feb 2015
avatar zero-24
zero-24 - comment - 27 Feb 2015

thanks @Kubik-Rubik

avatar Hils
Hils - comment - 27 Feb 2015

got pr done - won't be a moment!

Add a Comment

Login with GitHub to post a comment