[#6194] - Issue with content languages access in 3.4.0 (replaces #6172)
- Closed
- 27 Feb 2015
- Medium
- Build: staging
- Easy Test
- # 6194
- Diff
- infograf768:languages_assets
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
To test, create a basic multilanguage site with 3.4.0. Easiest is to use the functionnality when installing Joomla.
Then edit with phpmyadmin the _languages table in the database and set the access column values to 0.
Display frontend is broken.
Patch and test again.
joomla-cms-bot
- | Labels |
Added:
?
|
||
I would also add sticky notification to admin to allow/force users to fix the database integrity issue so we can restore the new code later.
I don't think that isset() is needed as the variable should be always present..?
in the module we just indeed use if($language->access etc. the isset was not in the original PR implementing the access.
Now looking when it was added.
took off the isset.
I suggest to commit this for 3.4.1 and add, when ready, a postinstall message
RTC
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
@infograf768 postinstall can be found here: #6195
| Labels |
Removed:
?
|
||
| Easy | No | ⇒ | Yes |
| Status | Pending | ⇒ | Ready to Commit |
| Category | ⇒ | Multilanguage Plugins |
moving RTC to match the RTC label on github
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6194.
| Rel_Number | 0 | ⇒ | 6186 |
| Relation Type | ⇒ | Pull Request for |
JM can you just add a code comment above this line just adding
// @todo: In Joomla 2.5.4 and earlier access wasn't set properly and gives a value of 0
or something similar so in the future we can come back to it and try and apply a longer term fix?
done
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-27 10:55:28 |
Kubik-Rubik
-
in the future we can come back to it and try and apply a longer term fix?
I'd say we can remove it for 4.0. Because then we can assume everyone has saved the value (especially given we have the postinstall message). Also it allows to make backward incompatible changes.
You can't even assume it then, today we're making a fix for a change that was applied in 2.5.4, a release almost 3 years ago and on a previous major release branch. The only 'safe' assumption is that people will find ways to break things 
Sure enough, but at least we are allowed to break it :)
Imho it does not cost much to leave the check (which btw also exists in the switcher module).
Thanks. Looks fine to me.