@infograf768 i will add your test from here: #5781 (comment) If it is not ok let me know. Thanks.

One thing to consider here is that we are essentially removing a security filter.
As far as I see you cna now pass anything you want for that filter. It isn't sanitised anywhere. Or I at least didn't see it when I had a look. Which is very likely a security issue.

Disagree on removing a security filter. It is about filtering output, not security related.

Do object to the change:

• Select type plugin, folder Authentication to see the plugins
• Select type component, to see your components before the change, or get the message there are no components in authentication folder after the change.

My preference is the current implementation ignoring not applicable filter.

It's not security filter. At worst you end up having no results:

 WHERE folder='whateverstring'

Value is escaped, so there's nothing that can break.

I would prefer not ignoring the filter, though..

Thanks JSST and @sovainfo for checking. Fine for me then

Do you really want to piss off experienced administrator by forcing them to clear the filter when not applicable or do you want to tell dummies that the folder only applies to libraries and plugins and therefor is ignored for the other types!

Remember, you are changing functionality. You force people to do something extra because there are dummies that do something extra, which makes no sense, and don't understand the result.

I guess the point here is that it is the only place in core where the results of filtering is incorrect.

So, the filter for folder should be hidded when it doesn't apply?
Disagree with not beeing correct. It is doing exactly what is expected. For now, it is the only place where we have optional filters. For something that is meant for Super users, that should be an issue.

I agree to @infograf768 .
The results should reflect the filter settings and not the filter settings combined with some expert knowledge that you only get by studying the source code.

Don't need to study code, just use your brain. For the record N/A means not applicable. What are you doing here (referring to Extension manager->Manage), you lack the qualifications for Super user!

So, the filter for folder should be hidded when it doesn't apply?

That would indeed be the best.

@test Success
I prefer to see what I've selected even if it's nothing (exclusion). One more click. Who cares?
I think hard coded filter conditions by name ('plugin', 'library') are inflexible.

IMO just commit the patch and open a new PR for conditional fields in the frontend (the whole js-thing).

IMO this is a bug and should be fixed. Thank you @Erftralle! Merged.