Labels |
Added:
?
|
Status | New | ⇒ | Confirmed |
One can find the reason for this behaviour in the file administrator/components/com_installer/models/manage.php.
In the function getListQuery()
lines 326-329 the folder filter is only applied if the type filter has specific values (namely 'plugin', 'library', '').
if ($group != '' && in_array($type, array('plugin', 'library', '')))
{
$query->where('folder=' . $this->_db->quote($group == '*' ? '' : $group));
}
So, if the type filter is set to 'component' the folder filter is not applied, no matter what is set there.
For me, this behavior is at least unexpected. I'm sure, the one who wrote that code has a different opinion.
It would be easy to change that behaviour by changing the code to
if ($group != '' )
{
$query->where('folder=' . $this->_db->quote($group == '*' ? '' : $group));
}
Then, regarding to your example filter setting (namely 'component', 'captcha'), no records would be listed.
I'll do a pull request if this solution will be supported.
Hi, I'm not technically sounds like you but your suggestion sounds good. Can you made this change at your testing site and check this thoroughly? If it works nicely, then, you can made the pull request for this.
Thanks for your effort.
I do confirm that the code proposed is fine, Please make a PR.
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-20 13:40:20 |
Closed_By | ⇒ | zero-24 |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/5781
Closing as we have a PR by @Erftralle Thanks.
Confirmed
On 17 January 2015 at 09:29, Aasim Ali notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/