Labels |
Added:
?
|
In an LTR document, and most definitely in a table, all copy should be left aligned. The only exception I would make to that rule would be for items without text, like buttons and checkboxes, which usually look better centrally aligned within their <td>
.
what about with numbers?
Just want to get a complete answer before doing a big PR
On 13 February 2015 at 10:29, Seth Warburton notifications@github.com
wrote:
In an LTR document, and most definitely in a table, all copy should be
.
left aligned. The only exception I would make to that rule would be for
items without text, like buttons and checkboxes, which usually look better
centrally aligned within their—
Reply to this email directly or view it on GitHub
#6076 (comment).Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Well the browser default is left-aligned, as it is with the whole document. There's cases where, from a typographical perspective, it may be desirable to right align a column of numbers: http://practicaltypography.com/grids-of-numbers.html but I feel that's overkill here and requires far too much manual intervention.
Bootstrap's behaviour is to not apply any alignment on table contents: http://getbootstrap.com/css/#tables so this is strictly a template-designers choice and one which I personally don't feel is correct. In this case I think the appearance would be improved and the template codebase lightened simply by allowing the browser to do its thing and left-align everything. TBH even left aligned buttons and checkboxes look fine to me, I only highlighted those as a possible item where there might be valid disagreement (form elements aren't typically part of a normal table content).
You'd get a from me remove all .center classes on table cells.
yeah thats what I plan to do - especially when we have it on a thead and
not on a td and vice versa
On 13 February 2015 at 10:51, Seth Warburton notifications@github.com
wrote:
You'd get a [image: ] from me remove all .center classes on table
cells.—
Reply to this email directly or view it on GitHub
#6076 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Labels |
Removed:
?
|
Labels |
Added:
?
|
for changes!
My opinion: left for text, center for icons/images and right for numeric (id is always on the right now, and could be right align).
Almost as you did @brianteeman in Option 2 ;-)
My opinion: left for text, center for icons/images and right for numeric
I suspect that any changes made now would be overwritten by changes in 3.5 for JLayouts so am putting this on the backburner for now @phproberto and adding a 3.5 milestone
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-16 16:28:42 |
Closed_By | ⇒ | brianteeman |
Milestone |
Removed: |
Status | Closed | ⇒ | New |
Closed_Date | 2015-05-16 16:28:42 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-05-16 16:29:12 |
Closed_By | ⇒ | brianteeman |
@nternetinspired any thoughts?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6076.