? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Feb 2015

Throughout joomla the ID column just as a heading ID. But in the new com_installer&view=updatesites the heading is Update Site ID.

This simple PR makes the strings consistent as simply ID

avatar brianteeman brianteeman - open - 12 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 13 Feb 2015
Category Templates (admin) UI/UX
avatar infograf768
infograf768 - comment - 16 Feb 2015

Instead of modifying the value of the string, it would be better to use a Global string:
JGRID_HEADING_ID="ID"

avatar seagul30
seagul30 - comment - 16 Feb 2015

Tested the patch - it's working!
Column ID for Updatesites is now "ID".

Also checked that I can override the template string "JGRID_HEADING_ID" - is not working.
So I guess there is not yet a global string.

Is that going to change?
If not, I can set me test result to successful.

Please let me know.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6075.
avatar infograf768
infograf768 - comment - 17 Feb 2015

@seagul30
The suggestion is to change the code to use JGRID_HEADING_ID instead of modifying the value.
I.e. change in ROOT/administrator/components/com_installer/views/updatesites/tmpl/default.php, line 69:

<?php echo JHtml::_('grid.sort', 'COM_INSTALLER_HEADING_UPDATESITEID', 'update_site_id', $listDirn, $listOrder); ?>
to
<?php echo JHtml::_('grid.sort', 'JGRID_HEADING_ID', 'update_site_id', $listDirn, $listOrder); ?>

it gives the correct rendering:
screen shot 2015-02-17 at 07 10 43

avatar imanickam
imanickam - comment - 4 Mar 2015

This is true even in the screen "Extension Manager: Update Sites". The column heading for the ID is "Update Site ID".

Shall we also make this as ID? If so, a separate Issue Tracker has to be created?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6075.
avatar brianteeman
brianteeman - comment - 4 Mar 2015

There was a discussion at the time about this. Sorry I am not at my PC so
can't find it but it is on the tracker somewhere
On 4 Mar 2015 05:34, "imanickam" notifications@github.com wrote:

This is true even in the screen "Extension Manager: Update Sites". The
column heading for the ID is "Update Site ID".

Shall we also make this as ID? If so, a separate Issue Tracker has to be

created?

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/6075
http://issues.joomla.org/tracker/joomla-cms/6075.


Reply to this email directly or view it on GitHub
#6075 (comment).

avatar nonumber
nonumber - comment - 16 Mar 2015

I would agree with JM.
The JGRID_HEADING_ID should be used. And the COM_INSTALLER_HEADING_UPDATESITEID string can be removed from the language files.

avatar nonumber
nonumber - comment - 16 Mar 2015

PS: Same thing for COM_INSTALLER_HEADING_ID.

avatar brianteeman brianteeman - close - 22 Mar 2015
avatar brianteeman brianteeman - change - 22 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-22 09:06:15
avatar brianteeman brianteeman - close - 22 Mar 2015
avatar brianteeman brianteeman - head_ref_deleted - 22 Mar 2015

Add a Comment

Login with GitHub to post a comment