[#6072] - REDO Small JForm Improvements #6067
- Closed
- 7 Apr 2017
- Medium
- Build: staging
- # 6072
- Diff
- Mathewlenning:JForm-Cleaning
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Untainted version of #6067
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Rel_Number | ⇒ | 6067 | |
| Relation Type | ⇒ | Related to |
Unfortunately JArrayHelper::fromObject isn't an option here. Because the original code was checking for JRegistry and JObject interfaces before converting the object to an array.
Of course we could replace that final return (array)$data;
but that would be changing the ouput, so BC would be at risk.
| Category | ⇒ | Libraries |
Same comment here regarding the merge conflicts. Any help would be appreciated.
It looks like this merge conflict is the result of another PR that resolved an issue with JObject, but this PR also fixes the bug and gives us a path to depreciate JObject dependencies in the future. So I hope you'll consider merging this.
Going to call @rdeutz as release manager of 3.7.0.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/6072.
recall @rdeutz
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/6072.
I would like to close this one, improvements are small and solving the conflicts seems to me more work as recreate the PR
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-07 16:21:54 |
| Closed_By | ⇒ | rdeutz |
Could you explain what is the improvement? And to convert an object to an array we have a function JArrayHelper::fromObject() that might could do a part of the job.