Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6067] - Small JForm Improvements

? Failure
Referenced as Related to: # 6072

User tests: Successful: Unsuccessful:

avatar Mathewlenning
Mathewlenning
12 Feb 2015

Cleaned up the bind and bindLevel methods to get rid of the duplicate foreach loop.

avatar Mathewlenning Mathewlenning - open - 12 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2015
Labels Added: ?
avatar javigomez
javigomez - comment - 12 Feb 2015

Github is not able to show the diff. If is possible I would suggest that you break the pull in smaller changes, it will be easier for us to review and test than checking 1500 additions at once.

avatar Mathewlenning
Mathewlenning - comment - 12 Feb 2015

It is actually it is only 58+, 48-

But I made the mistake of running code sniffer at commit 8fe3754
I'm going to figure out why the test are failing, then create a new pull request.

avatar Mathewlenning Mathewlenning - reference | fa8b1e1 - 12 Feb 15
avatar Mathewlenning Mathewlenning - close - 12 Feb 2015
avatar Mathewlenning
Mathewlenning - comment - 12 Feb 2015

Going to retry with clean branch

avatar Mathewlenning Mathewlenning - change - 12 Feb 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-02-12 17:51:49
avatar Mathewlenning Mathewlenning - close - 12 Feb 2015
avatar Mathewlenning Mathewlenning - head_ref_deleted - 6 Mar 2015

Add a Comment

Login with GitHub to post a comment