? Failure
Related to # 6022

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
11 Feb 2015

See #6022

I am also taking off an obsolete text-align: left; as text-alignment is decided by language.
Also, generatecss.php was not used in a former PR and the change concerning .nav-collapse.collapse.in was not included in the rtl.css.

Please test.

avatar infograf768 infograf768 - open - 11 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 11 Feb 2015
Title
Change tooltip appearance ( corrected #6022 )
Change tooltip appearance ( corrected #6022 )
Rel_Number 6022
Relation Type Related to
avatar zero-24 zero-24 - change - 12 Feb 2015
Category Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 12 Feb 2015
Easy No Yes
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2015
Title
Change tooltip appearance ( corrected #6022 )
Change tooltip appearance ( corrected #6022 )
avatar Hils
Hils - comment - 15 Feb 2015

@test

Confirm that tooltip originally was white text on black background and, after adding this patch, is now black text on white background.

Thanks for doing this :)

avatar RoterNagel RoterNagel - test_item - 14 Mar 2015 - Tested successfully
avatar christianhent christianhent - test_item - 14 Mar 2015 - Tested successfully
avatar RoterNagel
RoterNagel - comment - 14 Mar 2015

Yes, the change is there. But I dont't think it is the best solution or the final. It needs more difference between the tooltip and the backend. A shadow or more border. Because the colors from the tooltip are the same then from the backend.

If you are not focused on the screen while the tooltip appears you need a second to recognize the tooltip.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.
avatar adhocgraFX
adhocgraFX - comment - 14 Mar 2015

works fine, better readable with color change and better formatted with text align left


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.
avatar adhocgraFX adhocgraFX - test_item - 14 Mar 2015 - Tested successfully
avatar rgmears
rgmears - comment - 14 Mar 2015

@RoterNagel

Apologies that I haven't figured out yet how to correctly change the appropriate files. (Tabs to spaces, etc.)

If you want the border around the tooltip to be darker in template.less change line 959
from:

  • border:1px solid #aaa; to:
  • border:1px solid #111;

And if you want the arrow to be darker in variables.less change line 266
from:
+@tooltipArrowColor: #ddd;
to:
+@tooltipArrowColor: #111;


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.
avatar Yorgoz
Yorgoz - comment - 14 Mar 2015

@test works!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.
avatar Yorgoz Yorgoz - test_item - 14 Mar 2015 - Tested successfully
avatar bertmert
bertmert - comment - 16 Mar 2015

I love it(!!), but found this in article manager > open an article > Permissions.

BEFORE:
tooltip-before

AFTER:
tooltip-after

(Joomla! 3.4.1-dev Development [ Ember ] 24-February-2015 23:00 GMT )

avatar rgmears
rgmears - comment - 16 Mar 2015

@bertmert
I saw that a few times (also in permissions) but couldn't find an example of it when I looked for it later.

It seems that the use of the strong element to create a heading in most tooltips was not the best choice. Perhaps those few inline instances could be changed to <b> instead of <strong>.

Either that or change the <strong> headings to <span>. And then — when it's a heading — change the less file:
.tooltip-inner strong
to:
tooltip-inner span

Which of course means a lot of copy/paste in the core tooltip files.

avatar zero-24 zero-24 - alter_testresult - 11 Jun 2015 - RoterNagel: Not tested
avatar zero-24 zero-24 - alter_testresult - 11 Jun 2015 - Yorgoz: Not tested
avatar zero-24 zero-24 - alter_testresult - 11 Jun 2015 - adhocgraFX: Not tested
avatar zero-24 zero-24 - alter_testresult - 11 Jun 2015 - christianhent: Not tested
avatar designbengel designbengel - test_item - 24 Oct 2015 - Tested successfully
avatar designbengel
designbengel - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 6d1f7e0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.

avatar designbengel designbengel - test_item - 24 Oct 2015 - Tested unsuccessfully
avatar designbengel
designbengel - comment - 24 Oct 2015

I have tested this item :red_circle: unsuccessfully on 6d1f7e0

Sorry - found that the Backend-loginscreen went white instead of blue background caused by this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.

avatar designbengel
designbengel - comment - 24 Oct 2015

The Login Screen went white instead of blue caused by this patch. Can anyone confirm this?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.

avatar brianteeman
brianteeman - comment - 24 Oct 2015

@designbengel is that resolved when you clear the browser cache?

avatar bertmert
bertmert - comment - 24 Oct 2015

Concerning comments
#6050 (comment)
#6050 (comment)

and strong issue

I think the easiest solution to solve would be to change lines
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/html.php#L920-L925

like this (replace strong by span and CSS class)

$result = '<span class="tooltip-title">' . $title . '</span>';
...
$result = '<span class="tooltip-title">' . $title . '</span><br />' . $content;

then change line

.tooltip-inner strong {

to

.tooltip-inner .tooltip-title {

of this PR.

Why: There are too many language placeholders used in tooltips with strong-tags in it and not used as title..

The BR tag between $title and $content was already present.

Edition: Maybe a DIV would be better than SPAN because of HTML validation if block tags are used in title or content.

avatar KingLouis1 KingLouis1 - test_item - 24 Oct 2015 - Tested successfully
avatar KingLouis1
KingLouis1 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 6d1f7e0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.

avatar bertmert
bertmert - comment - 24 Oct 2015

Sorry, how could you test it successfully? This problem (#6050 (comment)) would break lots of tooltips in ISIS

avatar designbengel
designbengel - comment - 24 Oct 2015

@brianteeman no it stays white in background. screen shot 2015-10-24 at 10 54 43


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.

avatar bertmert
bertmert - comment - 25 Oct 2015

@designbengel
@brianteeman

#6050 (comment)

I compared template.less before and after this patch

This line has been removed

background-color: @loginBackground;

https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/isis/less/template.less#L89

Sorry, couldn't find the patch where this happened

avatar joomla-cms-bot
joomla-cms-bot - comment - 25 Oct 2015

This PR has received new commits.

CC: @adhocgraFX, @christianhent, @designbengel, @KingLouis1, @RoterNagel, @Yorgoz


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6050.

avatar infograf768
infograf768 - comment - 25 Oct 2015

@bertmert
The PR was far behind as it was made in February, therefore the error you got.

I have now updated it, following your suggestions.
I changed a bit to use font-weight: bold; for the Title and I also changed the border to 2px to make the tooltip stahd out better.

test for strong can be done in Languages->Overrides ->Edit an override or create a New one in the Text field tooltip.

screen shot 2015-10-25 at 09 31 25

avatar infograf768
infograf768 - comment - 25 Oct 2015

If issues, I will make a new PR

avatar infograf768
infograf768 - comment - 25 Oct 2015

yeah I was sure of that ;)
Folks, you can still test the results but we need new system tests as we move from to a span.

@Bakual @zero-24
Could you help for that as this is out of my scope ;)

avatar bertmert
bertmert - comment - 25 Oct 2015

@infograf768
Thank you. Now I understand. For me Github and PRs (hierarchy) are still obfuscating.

avatar infograf768
infograf768 - comment - 25 Oct 2015

Please test and comment in #8150
I am closing this one.

avatar infograf768 infograf768 - change - 25 Oct 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-10-25 09:17:48
Closed_By infograf768
avatar infograf768 infograf768 - close - 25 Oct 2015

Add a Comment

Login with GitHub to post a comment