User tests: Successful: Unsuccessful:
See #6022
I am also taking off an obsolete text-align: left;
as text-alignment is decided by language.
Also, generatecss.php was not used in a former PR and the change concerning .nav-collapse.collapse.in
was not included in the rtl.css.
Please test.
Labels |
Added:
?
|
Title |
|
||||||
Rel_Number | ⇒ | 6022 | |||||
Relation Type | ⇒ | Related to |
Category | ⇒ | Templates (admin) UI/UX |
Easy | No | ⇒ | Yes |
Title |
|
Yes, the change is there. But I dont't think it is the best solution or the final. It needs more difference between the tooltip and the backend. A shadow or more border. Because the colors from the tooltip are the same then from the backend.
If you are not focused on the screen while the tooltip appears you need a second to recognize the tooltip.
works fine, better readable with color change and better formatted with text align left
Apologies that I haven't figured out yet how to correctly change the appropriate files. (Tabs to spaces, etc.)
If you want the border around the tooltip to be darker in template.less change line 959
from:
And if you want the arrow to be darker in variables.less change line 266
from:
+@tooltipArrowColor: #ddd;
to:
+@tooltipArrowColor: #111;
@test works!
@bertmert
I saw that a few times (also in permissions) but couldn't find an example of it when I looked for it later.
It seems that the use of the strong element to create a heading in most tooltips was not the best choice. Perhaps those few inline instances could be changed to <b> instead of <strong>.
Either that or change the <strong> headings to <span>. And then — when it's a heading — change the less file:
.tooltip-inner strong
to:
tooltip-inner span
Which of course means a lot of copy/paste in the core tooltip files.
I have tested this item successfully on 6d1f7e0
I have tested this item unsuccessfully on 6d1f7e0
Sorry - found that the Backend-loginscreen went white instead of blue background caused by this patch.
The Login Screen went white instead of blue caused by this patch. Can anyone confirm this?
@designbengel is that resolved when you clear the browser cache?
Concerning comments
#6050 (comment)
#6050 (comment)
and strong issue
I think the easiest solution to solve would be to change lines
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/html.php#L920-L925
like this (replace strong by span and CSS class)
$result = '<span class="tooltip-title">' . $title . '</span>';
...
$result = '<span class="tooltip-title">' . $title . '</span><br />' . $content;
then change line
.tooltip-inner strong {
to
.tooltip-inner .tooltip-title {
of this PR.
Why: There are too many language placeholders used in tooltips with strong-tags in it and not used as title..
The BR tag between $title and $content was already present.
Edition: Maybe a DIV would be better than SPAN because of HTML validation if block tags are used in title or content.
I have tested this item successfully on 6d1f7e0
Sorry, how could you test it successfully? This problem (#6050 (comment)) would break lots of tooltips in ISIS
@brianteeman no it stays white in background.
I compared template.less before and after this patch
This line has been removed
background-color: @loginBackground;
Sorry, couldn't find the patch where this happened
This PR has received new commits.
CC: @adhocgraFX, @christianhent, @designbengel, @KingLouis1, @RoterNagel, @Yorgoz
@bertmert
The PR was far behind as it was made in February, therefore the error you got.
I have now updated it, following your suggestions.
I changed a bit to use font-weight: bold; for the Title and I also changed the border to 2px to make the tooltip stahd out better.
test for strong can be done in Languages->Overrides ->Edit an override or create a New one in the Text field tooltip.
If issues, I will make a new PR
@infograf768
Thank you. Now I understand. For me Github and PRs (hierarchy) are still obfuscating.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-25 09:17:48 |
Closed_By | ⇒ | infograf768 |
@test
Confirm that tooltip originally was white text on black background and, after adding this patch, is now black text on white background.
Thanks for doing this :)