? Success

User tests: Successful: Unsuccessful:

avatar thongredweb
thongredweb
11 Feb 2015

Hi guys,

When working on apply "Versioning" feature for my extension, I found a bug that the 'history_limit' is not effected, the Content History always get this option from com_content, not from my extension even I have it in config.xml.

This PR is make Content History load 'history_limit' from other extension like the way load 'save_history' option.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar thongredweb thongredweb - open - 11 Feb 2015
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2015
Labels Added: ?
avatar javigomez
javigomez - comment - 11 Feb 2015

I can confirm the issue, see the video: https://www.youtube.com/watch?v=whlPmP4wzm8

Tagging @dextercowley since he was the creator of the versioning feature

avatar javigomez
javigomez - comment - 11 Feb 2015

@test the patch fixes the issue:

screen shot 2015-02-11 at 12 42 24

results in:

screen shot 2015-02-11 at 12 42 03

avatar brianteeman brianteeman - change - 11 Feb 2015
Title
[Fix] History Limit option from other extension does not have effect
[Fix] Version History Limit option from other extension does not have effect
avatar brianteeman
brianteeman - comment - 11 Feb 2015

Adjusted title to include "version"


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6049.
avatar brianteeman brianteeman - test_item - 11 Feb 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Feb 2015

@test I can confirm the issue shown in the video and after applying the patch the issue is resolved


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6049.
avatar javigomez
javigomez - comment - 11 Feb 2015

Just got feedback from Mark giving an okay to the patch.

Since we have two valid tests moving this to RTC

avatar javigomez javigomez - change - 11 Feb 2015
Labels Added: ?
avatar javigomez javigomez - test_item - 11 Feb 2015 - Tested successfully
avatar infograf768 infograf768 - change - 11 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-11 16:35:15
avatar infograf768 infograf768 - close - 11 Feb 2015
avatar infograf768 infograf768 - reference | - 11 Feb 15
avatar infograf768 infograf768 - merge - 11 Feb 2015
avatar infograf768 infograf768 - close - 11 Feb 2015
avatar zero-24 zero-24 - close - 11 Feb 2015
avatar infograf768
infograf768 - comment - 11 Feb 2015

Thanks. Merged.

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment