[#5974] - Requiring valid title for menu items
- Closed
- 22 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 5974
- Diff
- thebeuving:issue5650
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Requiring more than a space to create a valid title
jissues-bot
- | Labels |
Added:
?
|
||
| Rel_Number | ⇒ | 5650 | |
| Relation Type | ⇒ | Pull Request for |
@test issue observed and problem resolved by PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5974.
I'm afraid so. No new strings from now unless absolutely essential. As this is an old bug it can wait for after 3.4
Alright that makes sense, does that mean I just need to resubmit the pull request to staging branch after Joomla 3.4 is released, or will it automatically get re-evaluated at that time?
We'll take care of it when 3.4 is released. But please give us a prod by mailing on here if it looks like we've forgotten :)
| Milestone |
Added: |
||
Set the Milestone to 3.4.1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5974.
| Category | ⇒ | Administration Components |
| Easy | No | ⇒ | Yes |
As this PR modifies the library, please change the new string to a JLIB one and add it in both en-GB.lib_joomla.ini (front and back)
Example of existing string in core:
JLIB_DATABASE_ERROR_MENU_UNIQUE_ALIAS
Yes, language string should be named:
See the category.php and module.php as example:
// Check for a title.
if (trim($this->title) == '')
{
$this->setError(JText::_('JLIB_DATABASE_ERROR_MUSTCONTAIN_A_TITLE_CATEGORY'));
return false;
}
You could also keep the comments the same.
Ok I went ahead and made those adjustments.
| Status | Pending | ⇒ | Ready to Commit |
RTC as we have two successful tests. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5974.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-22 03:09:57 |
Bakual
-
Merged! Thanks!
| Labels |
Added:
?
|
||
This is a valid issue BUT as we are in language string freeze I fear it may have to wait until after 3.4
@wilsonge is that true
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5974.