Feeling Lucky
?
[#5951] - ajax_com add check for plugin
- Closed
- 3 Feb 2015
- Medium
- Build: master
- # 5951
For plugin there should be a similar checking done for plugin as for module.
I used this sample code in ajax.php:
..
elseif ($input->get('plugin'))
{
$plugin = $input->get('plugin');
if (JPluginHelper::importPlugin('ajax', $plugin))
{
$dispatcher = JEventDispatcher::getInstance();
$plugin = ucfirst($plugin);
try
{
$results = $dispatcher->trigger('onAjax' . $plugin);
}
catch (Exception $e)
{
$results = $e;
}
}
else
$results = new LogicException(JText::sprintf('COM_AJAX_PLUGIN_NOT_ACCESSIBLE', $plugin), 404);
}
...
Additional comments
wilsonge
- comment
- 3 Feb 2015
He's saying that we should throw a logic exception if no plugin exists with the given name comparing the sample code to the code in 3.3.6
wilsonge
- comment
- 3 Feb 2015
The event will still start with onAjax
jschmi01
- comment
- 3 Feb 2015
Ok - thanks! tested my system-plugin with using &group=system - works perfectly
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-03 20:48:11 |
| Closed_By | ⇒ | zero-24 |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-03 20:48:12 |
zero-24
- comment
- 3 Feb 2015
Thanks for the update @jschmi01 so I'm closing here. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5951.
jissues-bot
- comment
- 3 Feb 2015
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/5951
| Labels |
Added:
?
|
||
I'm not sure what you mean.
com_ajaxsupports also plugins. The only restriction so far is that they have to be in the specific ajax plugin group.This restriction will be removed with 3.4.0.
For more details see #3938
If that is not what you meant, please be more descriptive and if possible create a PR (since you already seem to have some code)