Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5950] - [REFACTORING] Removing unnecessary trim in mod_languages

? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
2 Feb 2015

This trim is not necessary. It does not remove any UTF8 characters and multiple spaces in HTML are always contracted into one space. At the same time, the p-tag around the text lets the space vanish completely. This is simply an unnecessary function call and in worst case forces the JString library to be loaded where it doesn't have to be.

avatar Hackwar Hackwar - open - 2 Feb 2015
avatar jissues-bot jissues-bot - change - 2 Feb 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 3 Feb 2015
Category ⇒ Front End Modules
avatar vdespa
vdespa - comment - 14 Mar 2015

Confirmed. Trim is indeed not necessary. @test - everything works fine!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950.

avatar vdespa vdespa - test_item - 14 Mar 2015 - Tested successfully
avatar vdespa vdespa - change - 14 Mar 2015
Category Front End Modules ⇒ Code style Front End Modules
avatar vdespa vdespa - change - 14 Mar 2015
Title
…
Removing unnecessary trim in mod_languages
[REFACTORING] Removing unnecessary trim in mod_languages
Priority Medium ⇒ Low
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2015
Title
…
Removing unnecessary trim in mod_languages
[REFACTORING] Removing unnecessary trim in mod_languages
avatar PhocaCz PhocaCz - test_item - 24 Oct 2015 - Tested successfully
avatar PhocaCz
PhocaCz - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 226ffe5

Hi, testing now, confirmed, this is not needed there, it works OK.

Jan

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950.

avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Oct 2015

Thank you @Hackwar and testers! Will be merged... ;-)

avatar Kubik-Rubik Kubik-Rubik - test_item - 24 Oct 2015 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 226ffe5

vdespa tested this item successfully!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950.

avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Oct 2015

Thank you @Hackwar. Solved conflicts and merged with: a279c04

avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-24 14:41:46
Closed_By ⇒ Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment