? Success

User tests: Successful: Unsuccessful:

avatar ggppdk
ggppdk
31 Jan 2015

Fix for ie8/ie9 placeholder / numberType support

avatar ggppdk ggppdk - open - 31 Jan 2015
avatar jissues-bot jissues-bot - change - 31 Jan 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 1 Feb 2015

this looks very similar #3024
can you please check whether it fix the problem? :wink:

avatar ggppdk
ggppdk - comment - 1 Feb 2015

#3024, seems to try to deal of the same problem,
but only inside validateField

My suggested fix is at a more proper place making sure that no member functions are called on non-object

I am sorry i did not connect pull request with e.g. this issue: #5411

This pull request fixes this:

In IE8 and IE9
form.elements also contains function names
(code is supposed to take care of this ?? but it does not)

After calling (exists in 2 places inside the file)
var self = elem.form.H5Form;

We need to test if "self" is an object aka a form element, and do this:
if (typeof self != 'object') return true;

The return true is needed so that function
validateField(...)
will work properly

avatar Fedik
Fedik - comment - 1 Feb 2015

if (typeof self != 'object') return true; it not really safe as null also object,
I would suggest just if(!elem.form || !elem.form.H5Form) return; .. as in another issue

avatar ggppdk
ggppdk - comment - 1 Feb 2015

@Fedik

Basically the problem is that: elem.form.H5Form
is 'undefined'

so your code will work too, but also checks if elem.form is 'undefined' (which i don't know if it is possible with existing code)

just we need: return true;
and not just: return;
so that validateField(...) will work

avatar Fedik
Fedik - comment - 1 Feb 2015

yes !elem.form.H5Form will check whether property is not: null, false, undefined or 0.
About return true you are right, of course

avatar ggppdk
ggppdk - comment - 1 Feb 2015

I have updated the PR according to Fedik suggestion

avatar Fedik
Fedik - comment - 1 Feb 2015

please update also html5fallback.js :wink:
as html5fallback-uncompressed.js only for debug mode

avatar brianteeman brianteeman - change - 1 Feb 2015
Category JavaScript
avatar ggppdk
ggppdk - comment - 2 Feb 2015

Added

avatar wilsonge wilsonge - change - 4 Feb 2015
Milestone Added:
avatar wilsonge wilsonge - change - 24 Feb 2015
Milestone Added:
avatar wilsonge wilsonge - change - 24 Feb 2015
Milestone Removed:
avatar C-Lodder
C-Lodder - comment - 17 Mar 2015

@ggppdk - I'm more than happy to test this as I have IE8 at work for testing purposes, however could you please explain the test process, so I know what to add and where?

Cheer,
Lodder

avatar wilsonge wilsonge - change - 17 Mar 2015
Milestone Added:
avatar wilsonge wilsonge - change - 17 Mar 2015
Milestone Removed:
avatar wilsonge wilsonge - change - 24 Mar 2015
Milestone Removed:
avatar brianteeman brianteeman - change - 18 Feb 2016
Status Pending Information Required
avatar brianteeman
brianteeman - comment - 18 Feb 2016

@ggppdk please provide some testing instructions as requested. I'm afraid that without testing instructions people just dont test things and it will sit here for another year. If instructions are not provided this will be closed in 4 weeks time.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5935.

avatar brianteeman brianteeman - change - 5 Apr 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-04-05 08:04:53
Closed_By brianteeman
avatar brianteeman brianteeman - close - 5 Apr 2016
avatar brianteeman brianteeman - close - 5 Apr 2016
avatar brianteeman
brianteeman - comment - 5 Apr 2016

Closed as stated above


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5935.

Add a Comment

Login with GitHub to post a comment