Labels |
Added:
?
|
Status | New | ⇒ | Confirmed |
Category | ⇒ | Templates (admin) UI/UX |
Thanks @brianteeman. The solution/problem can be found here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/view/application/html.php#L77
Simply setting hidemainmenu to false would solve the problem. The question is, if it breaks something?
That comes from #4844
On 29 January 2015 at 15:03, waader notifications@github.com wrote:
Thanks @brianteeman https://github.com/brianteeman. The
solution/problem can be found here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/view/application/html.php#L77Simply setting hidemainmenu to false would solve the problem. The question
is, if it breaks something?—
Reply to this email directly or view it on GitHub
#5906 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
From the link you gave me I clicked on History at the top
On 29 January 2015 at 15:11, waader notifications@github.com wrote:
Thanks! How did you find the "responsible" patch so quick?
@dgt41 https://github.com/dgt41 Could you have a look at this?
—
Reply to this email directly or view it on GitHub
#5906 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
No that is not correct. Yes changing class=tab to class=clearfix will
resolve the layout clutter but that is not what it is supposed to look like
See this screenshot from 3.3.6 showing the 5 tabs Site - system- server -
permissions - text filters
[image: Inline images 1]
On 29 January 2015 at 15:21, Dimitris Grammatiko notifications@github.com
wrote:
@waader https://github.com/waader It’s not related to #4844
#4844. It’s more a clearfix
problem (try renaming tab class to clearfix [image:
@brianteeman Thanks for the info. Learned something.
@brianteeman I was comparing the output with safari, thus I thought is a clearfix problem. But honestly I cannot relate the problem to disable menu PR.
I dont know why it relates to that PR but reverting it resolves the issue
On 29 January 2015 at 15:35, Dimitris Grammatiko notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman I was comparing the output
with safari, thus I thought is a clearfix problem. But honestly I cannot
relate the problem to disable menu PR.—
Reply to this email directly or view it on GitHub
#5906 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Just change the parameter to false.
@brianteeman @waader Found the problem https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/index.php#L128
If this line changed to <?php if ($app->input->getInt('hidemainmenu')) : ?>
remove the !
all work fine
So I think we should see why this line breaks the tabs...
Reading this http://stackoverflow.com/questions/12671708/whats-jrequestsetvarhidemainmenu-1 I would agree to revert #4844.
Status | Confirmed | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-29 19:13:24 |
Closed_By | ⇒ | brianteeman |
Closed_Date | 2015-01-29 19:13:24 | ⇒ | 2015-01-29 19:13:23 |
The issue us that the tabs are not being loaded
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5906.