?
avatar waader
waader
28 Jan 2015

The permission section in hathor > global configuration is somewhat distorted/misplaced.

This is how it looks like in firexfox 35.0.1:

hathor_firefox

And here a screenshot taken from IE 11:

hathor_ie

It displays nice though in google chrome. Tested with latest staging.

avatar waader waader - open - 28 Jan 2015
avatar jissues-bot jissues-bot - change - 28 Jan 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 28 Jan 2015
Status New Confirmed
avatar brianteeman
brianteeman - comment - 28 Jan 2015

The issue us that the tabs are not being loaded


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5906.
avatar zero-24 zero-24 - change - 28 Jan 2015
Category Templates (admin) UI/UX
avatar waader
waader - comment - 29 Jan 2015

Thanks @brianteeman. The solution/problem can be found here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/view/application/html.php#L77

Simply setting hidemainmenu to false would solve the problem. The question is, if it breaks something?

avatar brianteeman
brianteeman - comment - 29 Jan 2015

That comes from #4844

On 29 January 2015 at 15:03, waader notifications@github.com wrote:

Thanks @brianteeman https://github.com/brianteeman. The
solution/problem can be found here:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/view/application/html.php#L77

Simply setting hidemainmenu to false would solve the problem. The question
is, if it breaks something?


Reply to this email directly or view it on GitHub
#5906 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar waader
waader - comment - 29 Jan 2015

Thanks! How did you find the "responsible" patch so quick?

@dgt41 Could you have a look at this?

avatar brianteeman
brianteeman - comment - 29 Jan 2015

From the link you gave me I clicked on History at the top

On 29 January 2015 at 15:11, waader notifications@github.com wrote:

Thanks! How did you find the "responsible" patch so quick?

@dgt41 https://github.com/dgt41 Could you have a look at this?


Reply to this email directly or view it on GitHub
#5906 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 29 Jan 2015

@waader It’s not related to #4844. It’s more a clearfix problem (try renaming tab class to clearfix

avatar brianteeman
brianteeman - comment - 29 Jan 2015

No that is not correct. Yes changing class=tab to class=clearfix will
resolve the layout clutter but that is not what it is supposed to look like

  • it is supposed to be in tabs.

See this screenshot from 3.3.6 showing the 5 tabs Site - system- server -
permissions - text filters

[image: Inline images 1]

On 29 January 2015 at 15:21, Dimitris Grammatiko notifications@github.com
wrote:

@waader https://github.com/waader It’s not related to #4844
#4844. It’s more a clearfix
problem (try renaming tab class to clearfix [image:

avatar waader
waader - comment - 29 Jan 2015

@dgt41 Sorry, I can't do anything with it. I am lost.

avatar waader
waader - comment - 29 Jan 2015

@brianteeman Thanks for the info. Learned something.

avatar dgt41
dgt41 - comment - 29 Jan 2015

@brianteeman I was comparing the output with safari, thus I thought is a clearfix problem. But honestly I cannot relate the problem to disable menu PR.

avatar brianteeman
brianteeman - comment - 29 Jan 2015

I dont know why it relates to that PR but reverting it resolves the issue

On 29 January 2015 at 15:35, Dimitris Grammatiko notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman I was comparing the output
with safari, thus I thought is a clearfix problem. But honestly I cannot
relate the problem to disable menu PR.


Reply to this email directly or view it on GitHub
#5906 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar waader
waader - comment - 29 Jan 2015

Just change the parameter to false.

avatar dgt41
dgt41 - comment - 29 Jan 2015

@brianteeman @waader Found the problem https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/index.php#L128
If this line changed to <?php if ($app->input->getInt('hidemainmenu')) : ?> remove the ! all work fine
So I think we should see why this line breaks the tabs...

avatar dgt41
dgt41 - comment - 29 Jan 2015

Actually is easier to revert #4844

avatar waader
waader - comment - 29 Jan 2015
avatar dgt41
dgt41 - comment - 29 Jan 2015

Ok, please test: #5925

avatar brianteeman
brianteeman - comment - 29 Jan 2015

Closed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5906.
avatar brianteeman brianteeman - close - 29 Jan 2015
avatar brianteeman brianteeman - close - 29 Jan 2015
avatar brianteeman brianteeman - change - 29 Jan 2015
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2015-01-29 19:13:24
Closed_By brianteeman
avatar brianteeman brianteeman - change - 29 Jan 2015
Closed_Date 2015-01-29 19:13:24 2015-01-29 19:13:23

Add a Comment

Login with GitHub to post a comment