? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
27 Jan 2015

see: #5854

Testing:

Just test that Beez, protostar, Hathor and Isis still working (css and js files get loaded)

Can you review here @dgt41? :smile:

avatar zero-24 zero-24 - open - 27 Jan 2015
avatar jissues-bot jissues-bot - change - 27 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 27 Jan 2015
Category Templates (admin) Templates (site)
avatar zero-24 zero-24 - change - 27 Jan 2015
Easy No Yes
avatar zero-24 zero-24 - change - 27 Jan 2015
The description was changed
avatar zero-24
zero-24 - comment - 27 Jan 2015

Thanks @dgt41 should all fixed now :+1:

avatar waader
waader - comment - 27 Jan 2015

@test works for me!

avatar zero-24 zero-24 - alter_testresult - 27 Jan 2015 - waader: Tested successfully
avatar dgt41
dgt41 - comment - 27 Jan 2015

@test ok except that there are some missing echo

avatar zero-24
zero-24 - comment - 27 Jan 2015

Just fixed the echo's thanks :smile:

avatar dgt41
dgt41 - comment - 27 Jan 2015

Side note, I think we can ditch those Juri:root() from assets on /media folder e.g.:
This <link rel="stylesheet" href="<?php echo JUri::root(); ?>/media/jui/css/bootstrap-rtl.css" type="text/css" />
should be the same as this:
<link rel="stylesheet" href="/media/jui/css/bootstrap-rtl.css" type="text/css" />

avatar dgt41
dgt41 - comment - 27 Jan 2015

@zero-24 Forget my last comment, Joomla should also work on subfolders...

avatar zero-24
zero-24 - comment - 27 Jan 2015

@dgt41 ok thanks :+1:

avatar zero-24 zero-24 - alter_testresult - 27 Jan 2015 - dgt41: Tested successfully
avatar zero-24 zero-24 - change - 27 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 27 Jan 2015

Thanks to @dgt41, @waader for review and testing moving to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5895.
avatar brianteeman brianteeman - change - 28 Jan 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 29 Jan 2015

Thank you, Tobias ( @zero-24 )!

avatar Kubik-Rubik Kubik-Rubik - close - 29 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - reference | - 29 Jan 15
avatar Kubik-Rubik Kubik-Rubik - merge - 29 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - close - 29 Jan 2015
avatar zero-24 zero-24 - close - 29 Jan 2015
avatar Kubik-Rubik Kubik-Rubik - change - 29 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-29 10:23:58
avatar zero-24 zero-24 - head_ref_deleted - 29 Jan 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment