?
avatar wilsonge
wilsonge
21 Jan 2015

We're still using the mootools modal for the media manager window (https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/form/field/media.php#L374, mootools behaviour called on https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/form/field/media.php#L204).

It would be nice to convert this to the bootstrap modal after @smanzi 's awesome improvements in #5087 and remove this mootools dependency

Posting it as an issue to remind me or let someone else (@dgt41 or @smanzi ?) work on it as not gonna have the time until early next week to be able to work on this.

avatar wilsonge wilsonge - open - 21 Jan 2015
avatar jissues-bot jissues-bot - change - 21 Jan 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 22 Jan 2015
Title
Media form field uses mootools modal
Media form field and mootools
avatar dgt41
dgt41 - comment - 22 Jan 2015

I have some code already, so whenever ready (the renderer part) will make any edits and create a PR ????
Repo here
Also I think part of 3.5 should be:
#4563 Admin com_messages modal
#4645 Admin com_templates modals
#4661 Admin com_menus modals
#5652 Plugins editors-xtd modals
#5654 Form field content history
#5655 Form field User

avatar zero-24 zero-24 - change - 22 Jan 2015
Category JavaScript
avatar jissues-bot jissues-bot - change - 22 Jan 2015
Title
Media form field and mootools
Media form field uses mootools modal
avatar dgt41
dgt41 - comment - 22 Jan 2015

#5871 Form field Media

avatar dgt41
dgt41 - comment - 23 Jan 2015

Also another (hopefully this is the last one)
#5873 User note modal

Right now, some of those (old) PRs have conflicts or need some touches since the changes of #5087, will do it after 3.4 is out

avatar brianteeman brianteeman - change - 12 Nov 2015
Status New Information Required
avatar brianteeman
brianteeman - comment - 12 Nov 2015

Has this been resolved elsewhere?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5861.

avatar wilsonge wilsonge - change - 12 Nov 2015
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2015-11-12 15:55:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Nov 2015
avatar wilsonge wilsonge - close - 12 Nov 2015
avatar wilsonge
wilsonge - comment - 12 Nov 2015

This is just a list of PR's I think. The media manager using Mootools definitely got resolved

avatar dgt41
dgt41 - comment - 12 Nov 2015

Except the xtd buttons everything else is already solved. The xtd buttons is another one that needs to be done...

Add a Comment

Login with GitHub to post a comment