? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
18 Jan 2015

I find the labels used in the column to show where the module is assigned is unclear. This PR changes the strings a little.

Before
before

After
after

avatar brianteeman brianteeman - open - 18 Jan 2015
avatar jissues-bot jissues-bot - change - 18 Jan 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 18 Jan 2015

@test success


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.

avatar zero-24 zero-24 - test_item - 18 Jan 2015 - Tested successfully
avatar zero-24 zero-24 - change - 18 Jan 2015
Category Language & Strings
avatar wilsonge
wilsonge - comment - 18 Jan 2015

I personally think all except selected is clear. I agree with moving selected only to just selected though

avatar brianteeman
brianteeman - comment - 18 Jan 2015

I'm not bothered about that one. Anyone else have a comment?

avatar anibalsanchez
anibalsanchez - comment - 19 Jan 2015

@test success

@brianteeman Just wondering .. (I am not native english speaker) ... "Only on the pages selected"... should be "Only on the selected pages"?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.

avatar anibalsanchez anibalsanchez - test_item - 19 Jan 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Jan 2015

Yes that is better/correct english

avatar pe7er
pe7er - comment - 19 Jan 2015

@test
This PR changes the labels in the Module Manager overview page " Module Manager: Modules".
IMHO these new shorter styles are better...

avatar infograf768
infograf768 - comment - 19 Jan 2015

"All except selected" should stay imho.

avatar nternetinspired
nternetinspired - comment - 19 Jan 2015

Less text is better text IMO, this is a good change.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Because I really wanted to get the confusing "Selected only" changed I am updating the PR to remove the change to "all except selected" instead of the entire PR getting delayed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Update done and setting to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.

avatar brianteeman brianteeman - change - 19 Jan 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 19 Jan 2015
Labels Added: ?
avatar wilsonge wilsonge - close - 19 Jan 2015
avatar zero-24 zero-24 - close - 19 Jan 2015
avatar wilsonge wilsonge - change - 19 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-19 20:50:14
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment