[#5813] - module assignment
- Closed
- 19 Jan 2015
- Medium
- Build: staging
- # 5813
- Diff
- brianteeman:select
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I find the labels used in the column to show where the module is assigned is unclear. This PR changes the strings a little.
Before
After
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Language & Strings |
I personally think all except selected is clear. I agree with moving selected only to just selected though
I'm not bothered about that one. Anyone else have a comment?
@test success
@brianteeman Just wondering .. (I am not native english speaker) ... "Only on the pages selected"... should be "Only on the selected pages"?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.
Yes that is better/correct english
"All except selected" should stay imho.
Less text is better text IMO, this is a good change.
Because I really wanted to get the confusing "Selected only" changed I am updating the PR to remove the change to "all except selected" instead of the entire PR getting delayed.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.
Update done and setting to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-19 20:50:14 |
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
?
|
||
@test success
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5813.