? Success

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
18 Jan 2015

Executive summary

This patch brings a lost functionality (lost between 1.5 and 2.5 ) back. It allows to filter an archive view by category.

Backwards compatibility

Full b/c, no problems are expected

Translation impact

none

Testing instructions

  • Install a fresh Joomla! with testing data. Check under „All Front End Views“ the „Archived Articles“ view.
  • You should see one item.
  • Log into to backend and archive all articles at the first page of „Content/Article Manager“
  • Go back to the front end and click again on „Archived Articles“
  • You should see more then one article
  • Now apply patch
  • Go back to the front end and click again on „Archived Articles“
  • Nothing should have changed
  • Go to the backend and change the menu item „Archived Articles“ (menu: All Front End Views)
  • You should see a Category selection box

category-select

  • Select „Content Modules“ and save the menu item
  • Go back to the front end and check the „Archived Articles“ menu
  • Now you should see only 2 Articles „Popular Tags“ „Similar Tags“, if not please check in the backend if both articles are in the archive.
avatar rdeutz rdeutz - open - 18 Jan 2015
avatar jissues-bot jissues-bot - change - 18 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 18 Jan 2015
Category Components Front End
avatar zero-24 zero-24 - change - 18 Jan 2015
Easy No Yes
avatar rdeutz
rdeutz - comment - 18 Jan 2015

Correction on my comment, it was lost between 1.0.x and 1.5

avatar brianteeman
brianteeman - comment - 18 Jan 2015

@test works as described

@rdeutz do you think this should also be applied to the archive module?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5810.

avatar brianteeman brianteeman - test_item - 18 Jan 2015 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 19 Jan 2015

@test ok


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5810.

avatar anibalsanchez anibalsanchez - test_item - 19 Jan 2015 - Tested successfully
avatar infograf768
infograf768 - comment - 19 Jan 2015

Please use tabs instead of spaces for the new field in the xml

avatar infograf768
infograf768 - comment - 19 Jan 2015

@rdeutz
While we are here, what do you think if was added:

<?php if (empty($this->items)) : ?>
            <div class="alert alert-no-items">
                <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
            </div>
    <?php else : ?>
    <?php foreach ($this->items as $i => $item) : ?>
[...]
    <?php endforeach; ?>
    <?php endif; ?>

etc.

avatar Hackwar
Hackwar - comment - 19 Jan 2015

As I explained in great detail yesterday in the JBS chat, this PR is a bad idea for a series of reasons. This does not solve the routing issue that we have, it does not give the archive view a proper purpose and thus it rather encourages people to use this useless view, making the transition to 4.0 that much harder when we drop this view. Please don't merge this.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

@Hackwar for those not in the JBS chat and to keep the conversation in one place that is archived and searchable please explain the problem here


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5810.

avatar Hackwar
Hackwar - comment - 19 Jan 2015

I will try.

The archive view is an obsolete view, similar to the featured and the categories view. While the categories view can be completely replaced by a specific configuration of the category view, the archive and featured views are both waiting to be replaced by a multi-category implementation. Considering the different issues that we have with the archive view right now, I simply don't want to encourage people to use this view more than necessary, otherwise making the transition from 3.x to 4.0 so much harder for them.
To explain the issues that we have with the archive view: Right now the links to content items in the archive view do not point to the menu item of the archive view, but to the menu item where the content item was originally located. This is something that we logically can't change, even with a multi-category-implementation, and by making the archive view more attractive, this will be the next request by people. So I rather want to slowly fade the archive view from existence than to throw more at it.

This is the attempt of compressing the long discussion into a short text.

avatar brianteeman
brianteeman - comment - 19 Jan 2015

Setting to needs review so the PLT and CMS maintainers can make a decision. The code is tested and works as intended


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5810.

avatar brianteeman brianteeman - change - 19 Jan 2015
Status Pending Needs Review
avatar tflm84 tflm84 - test_item - 20 Aug 2015 - Tested successfully
avatar schnuti
schnuti - comment - 26 Aug 2015

I agree with Hackwar. Do not add funcionaliy here. Why not add a filter on archived categories/articles in the normal views? I guess the models allow it out of the box.

Did you test the SEO links from the Archived articles module with this PR implemented?
See also #7771

avatar wilsonge
wilsonge - comment - 7 May 2016

Closing this for 2 reasons:
1) I agree with Hannes assessment
2) I think this feature is not needed - if only 1 person has asked for it in the 10 years since 1.5 came out it clearly is obsolete

avatar wilsonge wilsonge - change - 7 May 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-05-07 10:00:20
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 May 2016

Add a Comment

Login with GitHub to post a comment