? Success
Pull Request for # 5786

User tests: Successful: Unsuccessful:

avatar prasoon2211
prasoon2211
18 Jan 2015

The problem was as @infograf768 said. We're using the $msg way to show the message here.
Sample:
screen shot 2015-01-18 at 7 38 55 pm

avatar prasoon2211 prasoon2211 - open - 18 Jan 2015
avatar jissues-bot jissues-bot - change - 18 Jan 2015
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Jan 2015

Could you please optimize it to one line:


$app->enqueueMessage(JText::_('COM_INSTALLER_UNABLE_TO_FIND_INSTALL_PACKAGE'), 'error');

Thank you!

avatar zero-24 zero-24 - change - 18 Jan 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 18 Jan 2015
Rel_Number 5786
Relation Type Pull Request for
Easy No Yes
avatar prasoon2211
prasoon2211 - comment - 21 Jan 2015

@Kubik-Rubik Hey. I've changed the fix to be in one line. Anything else?

avatar Kubik-Rubik
Kubik-Rubik - comment - 21 Jan 2015

@prasoon2211 Thank you, looks good for me. One more tester required!

avatar prasoon2211
prasoon2211 - comment - 24 Jan 2015

Someone test this please?
On Jan 21, 2015 9:21 PM, "Viktor Vogel" notifications@github.com wrote:

@prasoon2211 https://github.com/prasoon2211 Thank you, looks good for
me. One more tester required!


Reply to this email directly or view it on GitHub
#5809 (comment).

avatar zero-24 zero-24 - alter_testresult - 24 Jan 2015 - Kubik-Rubik: Tested successfully
avatar zero-24 zero-24 - change - 24 Jan 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 24 Jan 2015

@test success moving to RTC Thanks @prasoon2211


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5809.
avatar zero-24 zero-24 - test_item - 24 Jan 2015 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Jan 2015

Thank you for the PR @prasoon2211 and the test @zero-24!

avatar Kubik-Rubik Kubik-Rubik - change - 24 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-24 23:50:08
avatar Kubik-Rubik Kubik-Rubik - close - 24 Jan 2015
avatar zero-24
zero-24 - comment - 24 Jan 2015

wow cool quick merge :smile: Thanks @Kubik-Rubik

avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Jan 2015

GitHub notification mails make it possible! ;-)

Add a Comment

Login with GitHub to post a comment