User tests: Successful: Unsuccessful:
Labels |
Added:
?
|
Category | ⇒ | JavaScript |
After applying RTC PR #6294
I've added lines 194 to 201
https://github.com/bertmert/joomla-cms/blob/patch-3/media/system/js/validate-uncompressed.js#L194
Thus we do not need changes in
administrator/components/com_config/view/application/html.php
and we don't need file
media/com_config/js/validate-number.js
at all.
I made some successful tests by exchanging validate.js wirh changed validate-uncrompressed.js..
@jackkum What do you think about these changes?
(((Sorry, I don't know how to manage these changes correctly in github. Multiple files? Minify? Just know how to create a new PR with a single file.)))
Sorry, not enough time to peek here
@bertmert I think it can be usefull.
Fedik proposed this https://gist.github.com/phproberto/6933178
Just modify file validate-uncompressed.js and compress him in validate.js
git checkout -b number-validator
git add validate-uncompressed.js
git add validate.js
git commit -m "some desc"
git pull origin number-validator
and create a PR
I have tested this item successfully on b0210d1
Category | JavaScript | ⇒ | Fields JavaScript |
@roland-d
#9997 this is for validation only in com_config. There have some trouble with tests, i don't understand what is wrong
#9998 this is for global validation handler as proposed @peterlose
Choose one.
Close this PR?
@jackkum It's only a codestyle issue in that PR. See https://travis-ci.org/joomla/joomla-cms/jobs/124358513 at the bottom:
FILE: ...oomla-cms/administrator/components/com_config/view/application/html.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
52 | ERROR | Tabs must be used to indent lines; spaces are not allowed
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-20 08:14:31 |
Closed_By | ⇒ | brianteeman |
Please see #9998
Would it be possible to add the javascript directly into validate.js?