? Pending
Referenced as Pull Request for: # 5619

User tests: Successful: Unsuccessful:

avatar jackkum
jackkum
6 Jan 2015

Validation session lifetime on client side. (#5619)

avatar jackkum jackkum - open - 6 Jan 2015
avatar jissues-bot jissues-bot - change - 6 Jan 2015
Labels Added: ?
avatar losedk
losedk - comment - 6 Jan 2015

Would it be possible to add the javascript directly into validate.js?

avatar brianteeman brianteeman - change - 19 Jan 2015
Category JavaScript
avatar bertmert
bertmert - comment - 16 Mar 2015

After applying RTC PR #6294

I've added lines 194 to 201
https://github.com/bertmert/joomla-cms/blob/patch-3/media/system/js/validate-uncompressed.js#L194

Thus we do not need changes in
administrator/components/com_config/view/application/html.php
and we don't need file
media/com_config/js/validate-number.js
at all.

I made some successful tests by exchanging validate.js wirh changed validate-uncrompressed.js..

@jackkum What do you think about these changes?

(((Sorry, I don't know how to manage these changes correctly in github. Multiple files? Minify? Just know how to create a new PR with a single file.)))

avatar jackkum
jackkum - comment - 20 Mar 2015

Sorry, not enough time to peek here :baby:
@bertmert I think it can be usefull.
Fedik proposed this https://gist.github.com/phproberto/6933178
Just modify file validate-uncompressed.js and compress him in validate.js

git checkout -b number-validator
git add validate-uncompressed.js
git add validate.js 
git commit -m "some desc"
git pull origin number-validator

and create a PR

avatar RonakParmar RonakParmar - test_item - 30 Nov 2015 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 30 Nov 2015

I have tested this item :white_check_mark: successfully on b0210d1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5624.

avatar brianteeman brianteeman - change - 10 Mar 2016
Category JavaScript Fields JavaScript
avatar roland-d
roland-d - comment - 14 Apr 2016

@jackkum Could you please solve the merge conflicts, add a minified version of the JS file and give us an instruction on how to test this? Thanks.

avatar jackkum
jackkum - comment - 19 Apr 2016

@roland-d Ok.

avatar roland-d
roland-d - comment - 19 Apr 2016

@jackkum Thank you very much.

avatar jackkum
jackkum - comment - 20 Apr 2016

@roland-d
#9997 this is for validation only in com_config. There have some trouble with tests, i don't understand what is wrong :confused:
#9998 this is for global validation handler as proposed @peterlose
Choose one. :smiley:
Close this PR?

avatar Bakual
Bakual - comment - 20 Apr 2016

@jackkum It's only a codestyle issue in that PR. See https://travis-ci.org/joomla/joomla-cms/jobs/124358513 at the bottom:

FILE: ...oomla-cms/administrator/components/com_config/view/application/html.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 52 | ERROR | Tabs must be used to indent lines; spaces are not allowed
avatar jackkum
jackkum - comment - 20 Apr 2016

@Bakual Thank you!

avatar brianteeman brianteeman - change - 20 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-20 08:14:31
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 20 Apr 2016

Please see #9998


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5624.

avatar brianteeman brianteeman - close - 20 Apr 2016

Add a Comment

Login with GitHub to post a comment