@brianteeman User Name or Username?

Username

@test

I may be wrong but I'm not part of "all to know that ID should be numerical".
ID is a way of Identification that can be a number but alos a name, aka, whatever...

IMHO, it's not only a numerical identification way even if this particular case, maybe 'Username' is more suitable.

Anyway, the patch show 'User Name' at this point.

Thanks

@MAT978 if it displays the number it should say ID if it displays the name it should say username

@brianteeman nothing else but what I said even if a name IS an ID technically and legally speaking ;)

I think anyways for the sake of consistency it should be username across.

In this case what should be displayed is either User or User name (capitalized or not, TBD...) but definitely not Username as what is displayed (and you can choose amongst) are "the names of the users", and not their usernames (which BTW when creating a new user a labelled as Login Name)

@smz I agree, Either it should be 'Name of user' or 'user' only. Because username is same like login name

"Username" is a convention in Joomla. It does not mean "User Name" (or "Name of User") which exists as "Name". It should be "Login Name" indeed.
In French we use "Identifiant" for Joomla "Login Name" or "Username"

In Joomla, it seems we still have that confusion in a few places, examples:
COM_ADMIN_USER_FIELD_USERNAME_LABEL="Login Name"
COM_ADMIN_USER_FIELD_USERNAME_DESC="Enter the login name (User name) for the user."
and
en-GB.com_users.ini:33: COM_USERS_CONFIG_FIELD_CHANGEUSERNAME_DESC="Allow users to change their Login name when editing their profile."
en-GB.com_users.ini:34: COM_USERS_CONFIG_FIELD_CHANGEUSERNAME_LABEL="Change Login Name"
but
COM_USERS_HEADING_USERNAME_ASC="Username ascending"
COM_USERS_HEADING_USERNAME_DESC="Username descending"

COM_USER_REMIND_VIEW_DEFAULT_TITLE="Username Reminder Request"

JLIB_LOGIN_AUTHENTICATE="Username and password do not match or you do not have an account yet."
etc.

If we have to normalise, I suggest to use "User Name" (to use "Name" in column headings is OK) and "Login Name" when appropriate and get rid of "Username".

In the case concerned here, we should use "User Name" for this label as it is indeed the Name of the User which is displayed and NOT its "Username" ("Login Name")

You are correct that we are using two terms for the same thing in joomla.
Thats what the enGB working group aims to resolve. However the correct term
to use is username all one word
On 30 Dec 2014 07:35, "infograf768" notifications@github.com wrote:

"Username" is a convention in Joomla. It does not mean "User Name" (or
"Name of User") which exists as "Name". It should be "Login Name" indeed.
In French we use "Identifiant" for Joomla "Login Name" or "Username"

In Joomla, it seems we still have that confusion in a few places, examples:
COM_ADMIN_USER_FIELD_USERNAME_LABEL="Login Name"
COM_ADMIN_USER_FIELD_USERNAME_DESC="Enter the login name (User name) for
the user."
and
en-GB.com_users.ini:33: COM_USERS_CONFIG_FIELD_CHANGEUSERNAME_DESC="Allow
users to change their Login name when editing their profile."
en-GB.com_users.ini:34:
COM_USERS_CONFIG_FIELD_CHANGEUSERNAME_LABEL="Change Login Name"
but
COM_USERS_HEADING_USERNAME_ASC="Username ascending"
COM_USERS_HEADING_USERNAME_DESC="Username descending"

COM_USER_REMIND_VIEW_DEFAULT_TITLE="Username Reminder Request"

JLIB_LOGIN_AUTHENTICATE="Username and password do not match or you do not
have an account yet."
etc.

If we have to normalise, I suggest to use "User Name" (to use "Name" in
column headings is OK) and "Login Name" when appropriate and get rid of
"Username".

In the case concerned here, we should use "User Name" for this label as it
is indeed the Name of the User which is displayed and NOT its "Username"
("Login Name")

—
Reply to this email directly or view it on GitHub
#5540 (comment).

However the correct term to use is username all one word

I disagree. "Login Name" is correct, not "username". "Username" has been used since Mambo times because the table column is called "username"...
Anyhow, as I said above, in this case, none of the above apply and the PR is correct.

Agree or disagree ...

On 30 December 2014 at 10:31, infograf768 notifications@github.com wrote:

However the correct term to use is username all one word

I disagree. "Login Name" is correct, not "username". "Username" has been
used since Mambo times because the table column is called "username"...
Anyhow, as I said above, in this case, none of the above apply and the PR
is correct.

—
Reply to this email directly or view it on GitHub
#5540 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@infograf768 @brianteeman
Yeah! I agree, Our aim is to make the label meaningful & usable. The current PR is absolutely correct.(Which is my first PR )

I totally agree with @infograf768, but I'm wondering if this code shouldn't be modified to use #_users:username instead of #_users:name for selection as the latter is not unique and in case of duplicates there wouldn't be a way to choose the correct one (except by pure chance...)

Username should be the term. It is the term used by other Open Source Projects which are multilingual. The points of Login name or Log in name and whatever other hybrids exist in the fragmented (unguided) strings are the result of years of not using a style guide for en-GB language strings. What we are trying to fix now.

Not trying to cut others off but these decisions are for native en-GB speakers.

@test In this patch User Name (2 words) still shows up. However I agree that we should get rid of 'Login Name' as well and have one single identifier indeed

I'm wondering if this code shouldn't be modified to use #_users:username instead of #_users:name for selection as the latter is not unique and in case of duplicates there wouldn't be a way to choose the correct one (except by pure chance...)

Makes me wonder if there are any reason to accept the same Name for different users.

Makes me wonder if there are any reason to accept the same Name for different users.

I don't know about your name, but I know at least another "Sergio Manzi" and the number of "Mario Rossi" is in the order of the tens of thousands...

There is a MASSIVE difference between Real Name and Username

Username obviously has to be unique
Real name obviously does not have to be unique

There are two Brian Teeman in the world - Facebook will show us both as
Brian Teeman but we have obviously have different usernames

On 31 December 2014 at 11:23, Sergio Manzi notifications@github.com wrote:

Makes me wonder if there are any reason to accept the same Name for
different users.

I don't know about your name, but I know at least another "Sergio Manzi"
and the number of "Mario Rossi" is in the order of the tens of thousands...

—
Reply to this email directly or view it on GitHub
#5540 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Yes, and here we are talking about "Real Names"...

Sorry it is so hard to follow you guys as you constantly change topics and
wander off down other paths that are not related.

Learnt my lesson - I will just be ignoring

On 31 December 2014 at 11:29, Sergio Manzi notifications@github.com wrote:

Yes, and here we are talking about "Real Names"...

—
Reply to this email directly or view it on GitHub
#5540 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian this issue is all about the fact that a label is now used saying User ID where in fact the user's real name (#_com_users:name) is displayed.

Then, you're right, things have gone a little been drifting and someone started talking about if "Login Name" or "Username" should be used, but that is in fact totally OT here...

@assimali
Looks like some do not want to understand that in THIS PR, it is the Name of the user and not the user id or Username which is displayed.
To finish —at last— with this, can you update your PR and change the string value to "User" only. We do not need more anyway here.

@infograf768
Okay! I am updating PR.

@infograf768 Merge it, merge it!!

Merge it, merge it!!

... actually not: this PR re-defines the text for the COM_USERS_FIELD_USER_ID_LABEL string, but this is wrong. I think we don't use it anywhere else, but the string may have been used by 3rd parties assuming that it displays "User ID" (which seems reasonable due to the string name...).

The string is used in /com_users/models/forms/note.xml where the associated variable is indeed userid, but then in the notes view the "User (real) name" is displayed. I've not yet tracked where this changing of what is displayed is happening...

... I'm not getting what's going on here: shouldn't this be in JForm??

BTW, the note editing view is quite broken in Hathor: labels and fields are out of sync...

@smz
The name of the field is "user_id", but its type is "user".
This form type displays the users (real) names.
see https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/form/field/user.php#L89
Merging PR. Thanks.

Note: It is extremely unlikely that this field label string be used by a 3rd party.

@infograf768 I totally agree with the merging of this PR: "User" is a generic enough term that can be applied to the user's ID, user's name and user's username, and thus little harm can be done even in the unlikely event of a minor B/C breach.

Having said that, and from a pure theoretical point of view, I too had come to that line of code (and the one below (https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/form/field/user.php#L103), but the funny thing that was (and still does) puzzling me is that if in them you change $table->name into $table->username, still the "name" and not the "username" is displayed... This I can't understand...

if in them you change $table->name into $table->username, still the "name" and not the "username" is displayed... This I can't understand...

Not here. username displays in that case.