[#5426] - [fix] Fixing getArticleRoute() calls in featured default_links
- Closed
- 21 Dec 2014
- Medium
- Build: staging
- # 5426
- Diff
- shur:patch-10
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
There is no need to use catslug in Joomla 3.x because:
1. Core content component doesn't use catslug in article URLs;
2. Process link function - ContentHelperRoute::getArticleRoute - requires only catid.
/components/com_content/helpers/route.php
public static function getArticleRoute($id, $catid = 0, $language = 0)
After this PR all URLs to the articles must be identical as in content component.
jissues-bot
- | Labels |
Added:
?
|
||
@shur Issue confirmed and solution working.
@test success
Sorry but I think you should edit the test instructions: they mention "Category Blog", while this PR is for "Featured Articles". I'll also consider editing PRs titles to make it clear to which views each of the 3 apply...
IMHO, this PR will also reduce the number of duplicated URLs: without this PR an article previously listed in the "Leading" or "Intro" sections and that at a second time falls into the "Links" section will change its URL, while with this PR applied the URL will remain the same.
brianteeman
- | Category | ⇒ | SEF |
Successfull test.
| Status | Pending | ⇒ | Ready to Commit |
There are two successful tests already. Anything else is needed to get this PR merged?
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-21 09:16:02 |
Changed title to fit and merged. Thanks!
| Labels |
Removed:
?
|
||
How to test
Open Features Articles page and see how the article URLs look like in "Leading" or "Intro" sections:
(Menu -> Featured Articles -> Layout -> Leading or Intro Articles):
http://test.com/index.php?option=com_content&view=article&id=49:article-alias&catid=12&Itemid=101But the same articles have different URLs in Featured "Links" section
(Menu -> Featured Articles -> Layout -> Links):
http://test.com/index.php?option=com_content&view=article&id=49:article-alias&catid=12:category-alias&Itemid=101BUT there is one important moment. Your site template can use overrides for Featured Articles Layout with it's own behavior for article links creation. For test I recommend to use Protostar template which doesn't have overrides for com_content layouts.
After this PR is applied
Articles URLs in these two places are the same as in com_content component