[#5425] - Fixing getArticleRoute() calls
- Closed
- 17 Dec 2014
- Medium
- Build: staging
- # 5425
- Diff
- shur:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
There is no need to use catslug in Joomla 3.x because:
1. Core content component doesn't use catslug in article URLs;
2. Process link function - ContentHelperRoute::getArticleRoute - requires only catid (integer value).
/components/com_content/helpers/route.php
public static function getArticleRoute($id, $catid = 0, $language = 0)
jissues-bot
- | Labels |
Added:
?
|
||
How to test
- SEF must be disabled ( Global Configuration -> SEO Settings);
-
Open category blog page and see how the article URLs look like:
http://test.com/index.php?option=com_content&view=article&id=49:article-alias&catid=12&Itemid=101 -
But the same articles have different URLs in blog links items
(Menu -> Category Blog Item -> Blog layout -> Links ):http://test.com/index.php?option=com_content&view=article&id=49:article-alias&catid=12:category-alias&Itemid=101
After this PR is applied
Articles URLs in these two places are the same as in com_content component
@shur I can't replicate your behavior, but keep in mind that I'm testing in a multilingual environment.
Here, all the links I see in the "Category Blog" page with address:
/index.php?option=com_content&view=category&layout=blog&id=9&Itemid=106&lang=en
have URLs of this kind:
/index.php?option=com_content&view=article&id=2:english-in-english&catid=9&lang=en&Itemid=106
without the category alias.
This is true independently form the fact that the article title appears as a 'Leading Article', *Intro Article* or 'Link`
When you talk about 'Menu -> Category Blog Item -> Blog layout -> Links' you mean the articles links that in the Blog page appear after 'Leading Articles' and*Intro Articles*, right? Or am I missing something...
When you talk about 'Menu -> Category Blog Item -> Blog layout -> Links' you mean the articles links that in the Blog page appear after
Leading ArticlesandIntro Articles, right? Or am I missing something...
Yes, exactly.
BUT there is one important moment. Your site template can use overrides for Blog Layout with it's own behavior for article links creation. For test I recommend to use Protostar template which doesn't have overrides for com_content layouts.
brianteeman
- | Category | ⇒ | SEF |
@shur Yes, I'm testing with a fresh Joomla! install from the 'staging' code using the Protostar template.
I think I know what's happening here: the file you edited for this PR is the one used by the JLayouts interface, /layouts/joomla/content/blog_style_default_links.php, and the "Category Blog" view doesn't use it. The file used is /components/com_content/views/category/tmpl/blog_links.php where we don't have the catslug but just the catid.
I'm wondering how you can see the catslug in this view!! 
Your edit seems anyway correct: only problem is that we don't know if and where this layout is used.
My feeling is that it is not used at this time, but I may be wrong and probably the person who can say the definitive word on this is @phproberto, JLayouts father.
I was sure that this layout was used for links position in category block page, but found out that it's not true. It turns out that this layout is never used for anything in Joomla, yet there is probability that is used by third party extensions.
However it still has a mistake, and this PR fixes it.
Successfull test. Setting to RTC
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-17 13:16:57 |
Merged! Thanks!
| Labels |
Removed:
?
|
||
@shur Hi! I see what you did and seems to be correct, but, to make tester's life easier, can you add instructions on how to test your PR (affected views and behavior without/with your PR applied)?
Same goes for #5426 and #5427...
Thanks! Sergio