Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5420] - Eliminates minor javascript error in toolbar popup button

? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
13 Dec 2014

Whenever a modal is render through a toolbar popup button, an error is logged in the browser.

This is due to onClick been set as Url.

This PR changes onclick to value (acceptable option for buttons)

Testing

Apply #5386
There are two javascript errors logged in your browsers console (the second one Joomla.toggleSidebar is solved #5259)
Apply this PR
error should go away

avatar dgt41 dgt41 - open - 13 Dec 2014
avatar jissues-bot jissues-bot - change - 13 Dec 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Dec 2014
Category ⇒ JavaScript
avatar smanzi
smanzi - comment - 13 Dec 2014

@dgt41 confirmed issues and fixing by respective PRs
@test success

avatar smanzi smanzi - test_item - 13 Dec 2014 - Tested successfully
avatar roland-d
roland-d - comment - 14 Dec 2014

@test all good and fixes also a JS error on the banner tracks export.

avatar roland-d roland-d - change - 14 Dec 2014
Status Pending ⇒ Ready to Commit
avatar roland-d
roland-d - comment - 14 Dec 2014

Moving to RTC, we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5420.
avatar roland-d roland-d - test_item - 14 Dec 2014 - Tested successfully
avatar roland-d roland-d - close - 14 Dec 2014
avatar roland-d roland-d - change - 14 Dec 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-12-14 15:15:24

Add a Comment

Login with GitHub to post a comment