? Success
Related to # 2660

User tests: Successful: Unsuccessful:

avatar andergmartins
andergmartins
7 Dec 2014

New PR based on #2660

Plugins, modules and templates don't recognise params form from a config.xml file, only if the config tag is inside the manifest file. This is inconsistent since we can use a config.xml file in components.

avatar andergmartins andergmartins - open - 7 Dec 2014
avatar jissues-bot jissues-bot - change - 7 Dec 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 7 Dec 2014

@andergmartins

can you have a look into the CodeStyle errors to make travis happy?

FILE: ...ravis/build/joomla/joomla-cms/components/com_config/model/templates.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AND 9 WARNING(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
 111 | WARNING | Inline control structures are discouraged
 114 | ERROR   | Closing brace indented incorrectly; expected 1 spaces, found 2
 116 | WARNING | Scope modifier not specified for member variable "$formFile"
 119 | WARNING | Scope modifier not specified for member variable "$form"
 119 | WARNING | Scope modifier not specified for member variable "$formFile"
 126 | WARNING | Scope modifier not specified for member variable "$xml"
 126 | WARNING | Scope modifier not specified for member variable "$formFile"
 132 | WARNING | Scope modifier not specified for member variable "$form"
 132 | WARNING | Scope modifier not specified for member variable "$data"
 132 | WARNING | Scope modifier not specified for member variable "$group"
 133 | ERROR   | Closing brace indented incorrectly; expected 0 spaces, found 1
--------------------------------------------------------------------------------

Old JC Tracker by @andergmartins

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32929&start=0

How to reproduce the problem and/or test the patch::

To reproduce, move the tag from any plugin to a config.xml file, and try to load the plugin settings page.

avatar andergmartins
andergmartins - comment - 7 Dec 2014

Thanks @zero-24, just fixed.

avatar roland-d roland-d - change - 6 Sep 2015
Rel_Number 2660
Relation Type Related to
avatar roland-d
roland-d - comment - 6 Sep 2015

Hello @andergmartins

Thank you for your contribution.

The last comment here was on 8th December 2014. Can you please provide clear test instructions to be able to test / reproduce this issue.
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5342.

avatar brianteeman brianteeman - change - 12 Nov 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-11-12 13:12:47
Closed_By brianteeman
avatar brianteeman brianteeman - close - 12 Nov 2015
avatar brianteeman brianteeman - close - 12 Nov 2015
avatar brianteeman
brianteeman - comment - 12 Nov 2015

closed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5342.

Add a Comment

Login with GitHub to post a comment