User tests: Successful: Unsuccessful:
We don't need to have two exclamation marks in the notification message!
Labels |
Added:
?
|
Title |
|
I know but this is only a small change. Without this change it will remain ugly "forever" in the 2.5 branch... ;-)
hmm so @infograf768 needs to decide here.
Technically shouldn't joomla have one
On 7 Dec 2014 19:19, "Viktor Vogel" notifications@github.com wrote:
We don't need to have two exclamation marks in the notification message!
You can merge this Pull Request by running
git pull https://github.com/Kubik-Rubik/joomla-cms 2.5.x-Notification-Exclamation-Marks
Or view, comment on, or merge it at:
#5341
Commit Summary
- Removes one unnecessary exclamation mark
File Changes
- M administrator/language/en-GB/en-GB.plg_quickicon_eosnotify.ini https://github.com/joomla/joomla-cms/pull/5341/files#diff-0 (4)
Patch Links:
- https://github.com/joomla/joomla-cms/pull/5341.patch
- https://github.com/joomla/joomla-cms/pull/5341.diff
—
Reply to this email directly or view it on GitHub
#5341.
@brianteeman Yes, you are right. So the exclamation mark moved to the end of the sentence... ;-)
Title |
|
Yes and it shouldn't effect translators
Updated PR!
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-08 07:17:27 |
@Kubik-Rubik
@infograf768 frozen the language files for 2.5.x
https://groups.google.com/forum/#!topic/joomla-dev-cms/xD0PrjVXMIE