?

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
7 Dec 2014

We don't need to have two exclamation marks in the notification message!

avatar Kubik-Rubik Kubik-Rubik - open - 7 Dec 2014
avatar jissues-bot jissues-bot - change - 7 Dec 2014
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 7 Dec 2014
Title
Removes one unnecessary exclamation mark
Notifier Plugin - Removes one unnecessary exclamation mark
avatar Kubik-Rubik
Kubik-Rubik - comment - 7 Dec 2014

I know but this is only a small change. Without this change it will remain ugly "forever" in the 2.5 branch... ;-)

avatar zero-24
zero-24 - comment - 7 Dec 2014

hmm so @infograf768 needs to decide here.

avatar brianteeman
brianteeman - comment - 7 Dec 2014

Technically shouldn't joomla have one
On 7 Dec 2014 19:19, "Viktor Vogel" notifications@github.com wrote:

We don't need to have two exclamation marks in the notification message!

You can merge this Pull Request by running

git pull https://github.com/Kubik-Rubik/joomla-cms 2.5.x-Notification-Exclamation-Marks

Or view, comment on, or merge it at:

#5341
Commit Summary

  • Removes one unnecessary exclamation mark

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5341.

avatar Kubik-Rubik
Kubik-Rubik - comment - 7 Dec 2014

@brianteeman Yes, you are right. So the exclamation mark moved to the end of the sentence... ;-)

avatar Kubik-Rubik Kubik-Rubik - change - 7 Dec 2014
Title
Removes one unnecessary exclamation mark
Notifier Plugin - Removes one unnecessary exclamation mark
avatar brianteeman
brianteeman - comment - 7 Dec 2014

Yes and it shouldn't effect translators

avatar Kubik-Rubik
Kubik-Rubik - comment - 7 Dec 2014

Updated PR!

avatar infograf768 infograf768 - close - 8 Dec 2014
avatar infograf768 infograf768 - reference | ea26c84 - 8 Dec 14
avatar infograf768 infograf768 - merge - 8 Dec 2014
avatar infograf768 infograf768 - close - 8 Dec 2014
avatar infograf768 infograf768 - change - 8 Dec 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-12-08 07:17:27
avatar Kubik-Rubik Kubik-Rubik - head_ref_deleted - 8 Dec 2014

Add a Comment

Login with GitHub to post a comment