[#5338] - JModelAdmin: Batch optimizations
- Closed
- 10 Dec 2014
- Medium
- Build: staging
- # 5338
- Diff
- Hackwar:batchoptimizations
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR optimizes the batch process and removes a lot of duplicate code. It adds 2 new variables that let you define the tasks to do and a copymove task before those additional tasks. That copymove task might modify the IDs of the items to treat and thus needs to be handled differently.
This modification is backwards compatible. To test, please simply check that all batch processes in all combinations still work.
It would be preferable if #5317 would be merged first. This PR is based on those changes and will automatically adapt if #5317 is merged.
jissues-bot
- | Labels |
Added:
?
|
||
Now it should work. 
Tested successfully!
Thank you, @Hackwar!
Tested batch functions in: Banners, Contact, Menu, Modules and Content
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5338.
| Status | Pending | ⇒ | Ready to Commit |
A side note: The copy function in the batch process for menu entries still doesn't work, the entries are moved, not copied! Can somebody confirm it?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5338.
Thank you to @smanzi and @Kubik-Rubik
Just to clarify: That issue with the copy function is unrelated to this PR.
Yes, it has nothing to do with this PR! This PR is ready to be committed. 
Works fine here. Merging.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-10 18:11:05 |
#5317 merged. This PR does not apply anymore here (with eclipse)